ci: split Windows opencode unit tests#146
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 17 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR restructures the Windows unit test job matrix by splitting the original Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
4fa12b2 to
b650ef3
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the CI workflow tests to support sharding of Windows unit tests for the opencode package. It introduces three specific shards—opencode-session, opencode-config-project, and opencode-server-tools—and adds a comprehensive test to ensure all opencode test files are covered exactly once across these shards without duplicates or omissions. I have no feedback to provide.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
1 similar comment
✅ Actions performedReview triggered.
|
b650ef3 to
38d46a3
Compare
38d46a3 to
39dcaae
Compare
39dcaae to
4f2c928
Compare
Astro-Han
left a comment
There was a problem hiding this comment.
Nits only, no blockers. The shard plan and coverage contract are sound and the TDD-RED evidence for the missing test/auth entry is convincing. Leaving a handful of rough edges below, mostly P2/P3.
4f2c928 to
4dd200a
Compare
4dd200a to
f19b206
Compare
Summary
Split the advisory Windows opencode unit signal into three stable directory shards:
opencode-session,opencode-config-project, andopencode-server-tools.Why
The current
unit-windows-opencodejob is the long pole for advisory Windows CI. Recent successful runs showed the opencode Windows unit step commonly around 9 to 10 minutes and the whole check around 13 to 14 minutes. Sharding only the opencode Windows signal should reduce PR wall time while keeping Windows checks advisory.Related Issue
No issue. This is a small CI wall-time optimization with a narrow workflow-only scope.
How To Verify
TDD RED: after adding the coverage contract, temporarily omitted
test/authfrom the server-tools shard and confirmed the test failed with missingtest/auth/auth.test.ts.Fresh-eyes review: first review found the missing coverage contract, fixed; second review returned no findings.
Screenshots or Recordings
Not applicable, no visible UI changes.
Checklist
dev, and my PR title and commit messages use Conventional Commits in EnglishSummary by CodeRabbit
Release Notes