ci: split Windows unit signal by package by Astro-Han · Pull Request #139 · Astro-Han/pawwork

Astro-Han · 2026-04-22T10:44:54Z

Summary

split the advisory Windows unit signal into app, desktop, and opencode jobs
keep Windows package jobs outside the required ci / check aggregate
stop publishing separate failing Windows JUnit report checks while preserving package artifacts

Why

The previous unit-windows job ran the full unit suite in one advisory Windows job. A timeout or flaky failure in one package made the whole Windows signal noisy and hard to diagnose. Issue #137 scopes this to package-level Windows signals while keeping the required Linux gate unchanged.

Related Issue

Closes #137

How To Verify

bun --cwd packages/opencode test test/github/ci-workflow.test.ts
actionlint .github/workflows/ci.yml
git diff --check

Screenshots or Recordings

Not applicable, CI-only change.

Checklist

I linked the related issue, or stated why there is no issue
This PR has type, scope, and priority labels, or I requested maintainer labeling
I listed the relevant verification steps, including tests when behavior changed
I manually checked visible UI or copy changes when needed, with screenshots or recordings
I considered macOS and Windows impact for desktop, packaging, updater, signing, paths, shell, or permissions changes
I called out docs, release notes, dependencies, permissions, credentials, deletion behavior, or generated/local file changes when relevant
I am targeting dev, and my PR title and commit messages use Conventional Commits in English

Summary by CodeRabbit

Chores
- Restructured Windows CI testing pipeline to separate and run package-specific test suites independently, improving test isolation, artifact organization, and execution efficiency.
- Enhanced test infrastructure with improved configuration patterns and dynamic job generation for better maintainability, scalability, and test reporting.

coderabbitai · 2026-04-22T10:44:59Z

Warning

Rate limit exceeded

@Astro-Han has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 47 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 6 minutes and 47 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 12030efe-e318-43f1-8d41-7bc450f0ca4d

📥 Commits

Reviewing files that changed from the base of the PR and between 6b864d1 and 6c1bc0b.

📒 Files selected for processing (3)

.github/workflows/ci.yml
packages/opencode/test/github/ci-workflow.test.ts
packages/opencode/test/github/workflow-parser.ts

📝 Walkthrough

Walkthrough

Refactored Windows unit testing in CI workflow by splitting the single unit-windows job into three package-scoped jobs (unit-windows-app, unit-windows-desktop, unit-windows-opencode), each running targeted Turbo filters with artifact uploads. Updated workflow tests to verify per-package job behavior and extended workflow-parser type with optional defaults field.

Changes

Cohort / File(s)	Summary
CI Workflow Refactoring `.github/workflows/ci.yml`	Renamed `unit-windows` to `unit-windows-app`, increased timeout to 20 minutes, removed `permissions.checks: write`, and replaced JUnit publishing with artifact uploads. Added two new Windows jobs (`unit-windows-desktop`, `unit-windows-opencode`) with package-specific Turbo filters and per-package artifact paths. Updated Turbo cache keys to reflect new job names.
Workflow Test Updates `packages/opencode/test/github/ci-workflow.test.ts`	Introduced data-driven `unitPackages` definitions and derived job metadata arrays. Refactored assertions to dynamically verify three Windows unit jobs with per-package Turbo commands, artifact uploads (without JUnit publishing), and run-attempt-scoped artifact names. Updated aggregate job tests to include new `unit-windows-*` jobs in docs-only behavior checks.
Type Definitions `packages/opencode/test/github/workflow-parser.ts`	Extended `WorkflowJob` type with optional `defaults` field supporting `run.shell` configuration.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related issues

[Feature] Split Windows CI unit signal by package #137: Directly implements the feature to split the single unit-windows job into three package-scoped Windows unit jobs with per-package Turbo filters and artifact handling.
[Bug] Improve CI stability and split package unit jobs #121: Modifies CI workflow and workflow-contract tests to split single Windows unit job into per-package Windows unit jobs with updated test assertions.

Possibly related PRs

ci: support Intel and Windows release targets #89: Both modify workflow-parser types, extending GitHub Actions job configuration shape (main adds WorkflowJob.defaults.run.shell; related PR adds other step/workflow properties).
ci: split package unit jobs #125: Both refactor CI workflow and workflow tests to split package-scoped unit jobs with per-package Turbo filters and artifact/JUnit handling.

Poem

🐰 Three jobs now bloom where one did stand,
Windows tests split across the land,
Each package gets its rightful care,
With artifacts floating in the air! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'ci: split Windows unit signal by package' is concise, specific, and accurately summarizes the main change—splitting Windows unit jobs into separate package-level signals.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description follows the template structure with all major sections completed: Summary, Why, Related Issue, How To Verify, Screenshots/Recordings, and Checklist all present and appropriately filled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/feat-windows-ci-split

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request refactors the CI workflow tests to accommodate splitting the Windows unit test job into package-specific jobs for the app, desktop, and opencode packages. It introduces categorized job lists to manage test assertions for checkout, caching, and artifact handling. A review comment suggests further refactoring these lists by deriving job names from a shared package list to improve maintainability and ensure consistency across Linux and Windows job definitions.

Astro-Han · 2026-04-22T10:53:37Z

@coderabbitai review

coderabbitai · 2026-04-22T10:53:42Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Astro-Han

Reviewing the Windows CI split implementation. A few nitpicks below.

Astro-Han

Additional nitpicks on consistency and test coverage.

Astro-Han

One more observation on test coverage consistency.

Astro-Han added enhancement New feature or request ci Continuous integration / GitHub Actions windows Windows-specific flaky-test Non-deterministic test failure P1 High priority labels Apr 22, 2026

gemini-code-assist Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread packages/opencode/test/github/ci-workflow.test.ts Outdated

Astro-Han commented Apr 22, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml Outdated

Comment thread packages/opencode/test/github/ci-workflow.test.ts

Comment thread packages/opencode/test/github/ci-workflow.test.ts

Astro-Han commented Apr 22, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml

Comment thread .github/workflows/ci.yml Outdated

Comment thread packages/opencode/test/github/ci-workflow.test.ts

Astro-Han commented Apr 22, 2026

View reviewed changes

Comment thread packages/opencode/test/github/ci-workflow.test.ts Outdated

Comment thread packages/opencode/test/github/workflow-parser.ts

Astro-Han force-pushed the codex/feat-windows-ci-split branch from 43e88ec to 5c9219a Compare April 22, 2026 11:07

ci: split Windows unit jobs by package

6c1bc0b

Astro-Han force-pushed the codex/feat-windows-ci-split branch from 5c9219a to 6c1bc0b Compare April 22, 2026 11:25

Astro-Han mentioned this pull request Apr 22, 2026

Improve Windows compatibility and restore Windows unit signal #141

Closed

Astro-Han merged commit 4a928a6 into dev Apr 22, 2026
21 checks passed

Astro-Han deleted the codex/feat-windows-ci-split branch April 22, 2026 11:52

This was referenced Apr 22, 2026

ci: split Windows opencode unit tests #146

Merged

ci: launch packaged desktop smoke app #164

Merged

feat: enable default websearch #271

Merged

coderabbitai Bot mentioned this pull request May 3, 2026

ci: split Windows advisory checks #409

Merged

11 tasks

Conversation

Astro-Han commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Related Issue

How To Verify

Screenshots or Recordings

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Astro-Han commented Apr 22, 2026

Uh oh!

coderabbitai Bot commented Apr 22, 2026

Uh oh!

Astro-Han left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Astro-Han left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Astro-Han left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Astro-Han commented Apr 22, 2026 •

edited

Loading

coderabbitai Bot commented Apr 22, 2026 •

edited

Loading