fix: update this and return type in child class constructor #2574#2635
Merged
dcodeIO merged 3 commits intoAssemblyScript:mainfrom Jan 31, 2023
Merged
fix: update this and return type in child class constructor #2574#2635dcodeIO merged 3 commits intoAssemblyScript:mainfrom
dcodeIO merged 3 commits intoAssemblyScript:mainfrom
Conversation
MaxGraey
reviewed
Jan 28, 2023
dcodeIO
reviewed
Jan 30, 2023
dcodeIO
approved these changes
Jan 31, 2023
Member
|
Thanks! I guess this fixes #2574? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When use parent constructor as child default constructor, function signature should update
thisTypeandreturnTypeinstead of directly using parent constructor