chore(build): improve as dependency#206
Merged
faustbrian merged 3 commits intoArkEcosystemArchive:developfrom Feb 24, 2020
sleepdefic1t:chore(build)/improve-as-dep
Merged
chore(build): improve as dependency#206faustbrian merged 3 commits intoArkEcosystemArchive:developfrom sleepdefic1t:chore(build)/improve-as-dep
faustbrian merged 3 commits intoArkEcosystemArchive:developfrom
sleepdefic1t:chore(build)/improve-as-dep
Conversation
Improve paths when building C++ Crypto as a project dependency. - CMAKE_SOURCE_DIR -> CMAKE_INSTALL_PREFIX - `cmake/External.cmake` ln#7, ln#41, ln#84, ln#118 - `src/CMakeLists.txt` ln#10 - add `EXTERNAL_LIBRARY_INCLUDE` var to link ArduinoJson lib. - `cmake/External.cmake` ln#161 - `src/CMakeLists.txt` ln#131
Contributor
Author
|
@faustbrian |
faustbrian
approved these changes
Feb 24, 2020
sleepdefic1t
added a commit
that referenced
this pull request
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve paths when building C++ Crypto as a project dependency.
cmake/External.cmakeln#7, ln#41, ln#84, ln#118src/CMakeLists.txtln#10EXTERNAL_LIBRARY_INCLUDEvar to link ArduinoJson lib.cmake/External.cmakeln#161src/CMakeLists.txtln#131Checklist