refactor(identities): improve implementation#120
Merged
faustbrian merged 14 commits intoArkEcosystemArchive:developfrom Aug 8, 2019
sleepdefic1t:refactor(identities)/improve-implementation
Merged
refactor(identities): improve implementation#120faustbrian merged 14 commits intoArkEcosystemArchive:developfrom sleepdefic1t:refactor(identities)/improve-implementation
faustbrian merged 14 commits intoArkEcosystemArchive:developfrom
sleepdefic1t:refactor(identities)/improve-implementation
Conversation
This PR is mostly centered around improving the Identities implementation. Use of std::array replaces std::vector in many instances to avoid dynamic allocation. The result is a ~4x-6x gain in execution speed of relevant functions, and a reduced memory footprint overall. Specifically, this PR does the following: - refactors Identities classes. - adds hash class. - adds curve class. - adds str helpers. - adds base58 class. - moves hex helpers. - updates other classes to match changes. - adds relevant tests. - updates scrips, examples, documentation, and changelog.
codacy incorrectly analyzing header struct member as unused. Not at all the case.
Codecov Report
@@ Coverage Diff @@
## develop #120 +/- ##
===========================================
- Coverage 91.52% 91.49% -0.03%
===========================================
Files 30 34 +4
Lines 861 858 -3
===========================================
- Hits 788 785 -3
Misses 73 73
Continue to review full report at Codecov.
|
Contributor
Author
|
Codacy not config'd to watch develop. You can view the current PR at codacy.com/project/sleepdefic1t/cpp-crypto. The majority of the issues are documentation-style related. |
trailing return, comments, naming, etc
remove redundant strlen check.
testname helpers -> utils
…ies)/improve-implementation
Contributor
Author
|
this is ready, @faustbrian |
Contributor
Author
|
@faustbrian, good to go 👍 |
faustbrian
approved these changes
Aug 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mostly centered around improving the Identities implementation.
Use of std::array replaces std::vector in many instances to avoid dynamic allocation. The result is a ~4x-6x gain in execution speed of relevant functions, and a reduced memory footprint overall.
Specifically, this PR does the following:
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
WIFclass is nowWif, andIdentitiesnamespace is nowidentitiesper C++ code style guidelines.Does this PR release a new version?
The PR fulfills these requirements:
developbranch, not themasterbranch