Skip to content

chore: Visual Studio Support#122

Merged
faustbrian merged 2 commits intoArkEcosystemArchive:developfrom
ciband:bug/fix_visual_studio_support
Aug 7, 2019
Merged

chore: Visual Studio Support#122
faustbrian merged 2 commits intoArkEcosystemArchive:developfrom
ciband:bug/fix_visual_studio_support

Conversation

@ciband
Copy link
Contributor

@ciband ciband commented Aug 2, 2019 •
edited
Loading

Added back missing JSON file that integrates cmake build system into the Visual Studio IDE.

Cleared warnings.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost
Copy link

ghost commented Aug 2, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: Medium Less than 256 lines changed. label Aug 2, 2019
@ghost
Copy link

ghost commented Aug 2, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ciband ciband changed the base branch from master to develop August 2, 2019 23:10
@sleepdefic1t
Copy link
Contributor

sleepdefic1t commented Aug 3, 2019 •
edited
Loading

@ciband
Figured out macOS CI builds aren't triggered if you're tracking from your CircleCI account and do not have a macOS plan.
If you disable C++ Crypto from your CircleCI account,
subsequent PR's will default to the organization and trigger all PR checks 👍

@ghost ghost mentioned this pull request Aug 4, 2019
Closed
@ciband ciband changed the title Bug/fix visual studio support Fix Visual Studio Support Aug 5, 2019
@ciband
Copy link
Contributor Author

ciband commented Aug 5, 2019

@sleepdefic1t I've disabled my circleci for this repo. Are you able to re-trigger CI for this PR? I do not seem to have access.

@sleepdefic1t
Copy link
Contributor

sleepdefic1t commented Aug 5, 2019 •
edited
Loading

@ciband
Nope. It's still tied to your CircleCi account.
It would have to be closed and resubmitted in a new PR to get picked up by the Organization account...
That's doing too much. lol

Just from looking at it, that's totally legal in macOS and should have no issues.
std::vector<>::size just evaluates to an unsigned integer,
which was probably why Windows wanted you to be explicit with the initial value.

This looks good to go, @faustbrian 👍

@faustbrian faustbrian changed the title Fix Visual Studio Support chore: Visual Studio Support Aug 7, 2019
@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Aug 7, 2019
@ghost
Copy link

ghost commented Aug 7, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Aug 7, 2019
@faustbrian faustbrian merged commit 03288a3 into ArkEcosystemArchive:develop Aug 7, 2019
@ghost
Copy link

ghost commented Aug 7, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@ghost ghost mentioned this pull request Aug 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

1 more reviewer

@faustbrian faustbrian faustbrian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Medium Less than 256 lines changed. Status: Contributor Approved The pull request has been approved by a contributor.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ciband @sleepdefic1t @faustbrian