Skip to content

feat(api): add blockchain endpoint#104

Merged
faustbrian merged 9 commits intoArkEcosystemArchive:developfrom
sleepdefic1t:feat/blockchain
Jul 12, 2019
Merged

feat(api): add blockchain endpoint#104
faustbrian merged 9 commits intoArkEcosystemArchive:developfrom
sleepdefic1t:feat/blockchain

Conversation

@sleepdefic1t
Copy link
Contributor

@sleepdefic1t sleepdefic1t commented Jul 11, 2019

Was missing from prior versions.

This PR does the following:

  • added Blockchain Path and API Endpoint.
  • added Blockchain mock & tests.
  • updated CMake files.
  • updated documentation.
  • updated examples.
  • added to changelog.

What kind of change does this PR introduce?

  • Feature

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

sleepdefic1t and others added 4 commits June 1, 2019 15:47
@sleepdefic1t @faustbrian
docs: update documentation link (#94)
dcea4db
@faustbrian
refactor: remove version argument remains (#100)
8072e50
@sleepdefic1t
feat(api)/add-blockchain-endpoint
eaf303a 
- added Blockchain Path and API Endpoint.
- added Block mock & tests.
- updated CMake files.
- updated documentation.
- updated examples.
- added to changelog.
@sleepdefic1t
Update blockchain.cpp
710c995
@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Jul 11, 2019
@codecov-io
Copy link

codecov-io commented Jul 11, 2019

Codecov Report

Merging #104 into develop will increase coverage by 70.66%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #104       +/-   ##
===========================================
+ Coverage    26.93%   97.6%   +70.66%     
===========================================
  Files           14      15        +1     
  Lines          245     250        +5     
===========================================
+ Hits            66     244      +178     
+ Misses         179       6      -173
Impacted Files Coverage Δ
src/http/os/http.cpp 100% <ø> (+48.88%) ⬆️
src/api/paths.cpp 96.27% <0%> (+96.27%) ⬆️
src/include/cpp-client/http/http.h 100% <100%> (+40%) ⬆️
...c/include/cpp-client/api/blockchain/blockchain.hpp 100% <100%> (ø)
src/include/cpp-client/api/abstract.h 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39aebe...710c995. Read the comment docs.

sleepdefic1t and others added 5 commits July 11, 2019 07:49
@sleepdefic1t
docs: update documentation link (#94)
10d3718
@faustbrian @sleepdefic1t
refactor: remove version argument remains (#100)
f9f3c7b
@sleepdefic1t
feat(api)/add-blockchain-endpoint
dc73449 
- added Blockchain Path and API Endpoint.
- added Block mock & tests.
- updated CMake files.
- updated documentation.
- updated examples.
- added to changelog.
@sleepdefic1t
Update blockchain.cpp
e0961a9
@sleepdefic1t
Merge branch 'feat/blockchain' of https://github.com/sleepdefic1t/cpp…
71225dc 
…-client into feat/blockchain
@faustbrian faustbrian merged commit b1f6955 into ArkEcosystemArchive:develop Jul 12, 2019
@sleepdefic1t sleepdefic1t deleted the feat/blockchain branch July 15, 2019 18:56
This was referenced Oct 9, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

1 more reviewer

@faustbrian faustbrian faustbrian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sleepdefic1t @codecov-io @faustbrian