refactor: remove version argument remains#100
Merged
faustbrian merged 4 commits intomasterfrom Jul 7, 2019
Merged
Conversation
|
The ci/circleci: build-macos-9-3 job is failing as of 78f123beed4070c306498865eae66719dedbf966. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
This was referenced Jul 7, 2019
Merged
Fixes remaining changes from `refactor/legacy`. Specifically, - [abstract.h] - `explicit` keyword moved to single argument constructor. | per: https://google.github.io/styleguide/cppguide.html#Implicit_Conversions - [http.h] - added default constructor; - changed copy assignment operator to default. - [test/mock_api.h] - removed legacy version-value from constructor. - [test/mock_http.h] - removed default `MockHTTP()` constructor (now unneeded). - [test/http.h] - fixes to make tests pass with current devnet core. - future PR should be done to use some other source.
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 245 242 -3
=====================================
- Hits 245 242 -3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all code that related to setting an API-Version as Core 2.5 will only serve the v2 API.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranchIf adding a new feature, the PR's description includes: