fix: refactor legacy#102
Merged
faustbrian merged 1 commit intoArkEcosystemArchive:refactor/legacyfrom Jul 7, 2019
sleepdefic1t:fix/refactor/legacy
Merged
fix: refactor legacy#102faustbrian merged 1 commit intoArkEcosystemArchive:refactor/legacyfrom sleepdefic1t:fix/refactor/legacy
faustbrian merged 1 commit intoArkEcosystemArchive:refactor/legacyfrom
sleepdefic1t:fix/refactor/legacy
Conversation
Fixes remaining changes from `refactor/legacy`. Specifically, - [abstract.h] - `explicit` keyword moved to single argument constructor. | per: https://google.github.io/styleguide/cppguide.html#Implicit_Conversions - [http.h] - added default constructor; - changed copy assignment operator to default. - [test/mock_api.h] - removed legacy version-value from constructor. - [test/mock_http.h] - removed default `MockHTTP()` constructor (now unneeded). - [test/http.h] - fixes to make tests pass with current devnet core. - future PR should be done to use some other source.
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes remaining changes from
refactor/legacyin #100 .Specifically,
explicitkeyword moved to single argument constructor.MockHTTP()constructor (now unneeded).What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
The PR fulfills these requirements:
- [ ] It's submitted to then/adevelopbranch, not themasterbranch- [n/a ] New/updated tests are includedn/a