Add support for comment based attributes #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
==========================================
+ Coverage 81.56% 81.59% +0.02%
==========================================
Files 194 194
Lines 7671 7678 +7
==========================================
+ Hits 6257 6265 +8
+ Misses 1414 1413 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Argmaster
added a commit
that referenced
this pull request
Aug 11, 2024
This pull request adds simple support for comment based attributes with `G04 #@! <attr-type><attr-content>` syntax. Such attributes are represented by default non-comment tokes, so parsing Gerber file with comment based attributes and dumping it from PyGerber AST representation will result in comment based attributes being transformed to normal attributes. Resolves: #118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds simple support for comment based attributes with
G04 #@! <attr-type><attr-content>syntax. Such attributes are represented by default non-comment tokes, so parsing Gerber file with comment based attributes and dumping it from PyGerber AST representation will result in comment based attributes being transformed to normal attributes.Resolves: #118