For linear velocity, the data is earth-fixed but starts alligned with the robot body (x-forward)
For angular velocity, the gyro data is body-fixed.

Should we keep it that way ? Or do everything acording to NED ? This is easy to implement but the AP community needs to agree on how to do it

For linear velocity, the data is earth-fixed but starts alligned with the robot body (x-forward)
For angular velocity, the gyro data is body-fixed.

Should we keep it that way ? Or do everything acording to NED ? This is easy to implement but the AP community needs to agree on how to do it

As before, we want to follow ROS rep's as best as possible. In REP-147, it says, even for aerial vehicles, to follow REP-105.
https://ros.org/reps/rep-0147.html#coordinate-frames

That said, it doesn't clarify on NED vs ENU. For now, let's stick with ENU, since that's largely a convention in the ROS community, and this is a ROS interface.

I think it's totally reasonable, later, to add an alternative subset of topics in NED convention, if it's needed.

REP-103 solves the dispute between ENU vs NED:

For short-range Cartesian representations of geographic locations, use the east north up [5] (ENU) convention
For outdoor systems where it is desirable to work under the north east down [6] (NED) convention, define an appropriately transformed secondary frame with the "_ned" suffix

ENU should be default and we can add NED later, as you proposed. I will change the frame to ENU and commit it as a fixup

We spent some time testing, just deciding what coordinate system the orientation should follow on the vehicle. Likely, we will match what NAV2 is using, but I had issues bringing the examples up in NAV2.

Please rebase this on master to fix conflicts with the pose topic. Then, I can test it. Thanks!

Rebased and updated the axis orientation to follow ENU and what was agreed on #23480. Code comments were updated accordingly.
@Ryanf55 I've tested it in SITL with a controller and both the linear and angular velocities seem to check out! Feel free to check it