This repository was archived by the owner on May 30, 2018. It is now read-only.
Razer support and first-time device detection#21
Merged
Archomeda merged 2 commits intoArchomeda:masterfrom Dec 31, 2015
Merged
Conversation
# Conflicts: # README.md # src/Config/MainConfigFile.cpp # src/Config/MainConfigFile.h # src/Devices/DeviceCorsair.cpp # src/Devices/DeviceCorsair.h # src/Devices/DeviceLogitech.cpp # src/Managers/DeviceManager.cpp
Owner
|
There's a small issue regarding the detection of a first-time run. The code doesn't reach the part that says that there's no configuration found and it's using the default settings. This error is my fault, and I didn't notice it until now. The code basically checks if the directory exists of the config file, and not the actual file itself. But that directory is created somewhere else in the code if it doesn't exist (I think that might be the logger). I have fixed it locally already, so I'll merge this and commit my fix afterwards. Thanks! |
Archomeda
added a commit
that referenced
this pull request
Dec 31, 2015
Razer support and first-time device detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.