Skip to content

Conversation

@arcade-player
Copy link
Contributor

What does this PR do?
ad per #76 this PR adds tests and reviews existing ones on SQL related code
Motivation
increase coverage
Related issues
#76

@arcade-player arcade-player self-assigned this Sep 25, 2021
@arcade-player arcade-player force-pushed the feautue-76/add_unit_test_to_SQL branch 2 times, most recently from 64082be to d9bf0b6 Compare September 25, 2021 21:02
@arcade-player arcade-player linked an issue Sep 25, 2021 that may be closed by this pull request
@arcade-player arcade-player force-pushed the feautue-76/add_unit_test_to_SQL branch from 5d5bfd2 to 79a7db2 Compare September 29, 2021 20:59
@arcade-player arcade-player marked this pull request as ready for review September 29, 2021 21:03
@mergify mergify bot merged commit e6c64b3 into main Sep 29, 2021
@lvca lvca deleted the feautue-76/add_unit_test_to_SQL branch May 6, 2023 15:31
mergify bot added a commit that referenced this pull request Oct 11, 2025
…3.1 in /studio [skip ci]

Bumps [loader-runner](https://github.com/webpack/loader-runner) from 4.3.0 to 4.3.1.
Release notes

*Sourced from [loader-runner's releases](https://github.com/webpack/loader-runner/releases).*

> v4.3.1
> ------
>
> ### Fixes
>
> * Always set `resourcePath`, `resourceQuery` and `resourceHash` to empty string when `request` is empty.
>
> ### Performance
>
> * Speed up resource parsing.


Commits

* [`50310c0`](webpack/loader-runner@50310c0) chore(release): 4.3.1
* [`ac1e111`](webpack/loader-runner@ac1e111) refactor: logic
* [`5bd7e51`](webpack/loader-runner@5bd7e51) refactor: comments
* [`7a2b3c3`](webpack/loader-runner@7a2b3c3) perf: speed up resource parsing ([#83](https://redirect.github.com/webpack/loader-runner/issues/83))
* [`37abe09`](webpack/loader-runner@37abe09) refactor: update eslint config ([#82](https://redirect.github.com/webpack/loader-runner/issues/82))
* [`7cda5f8`](webpack/loader-runner@7cda5f8) fix: always set `resource`, `resourcePath`, `resourceQuery` and `resourceFrag...
* [`6bbadc7`](webpack/loader-runner@6bbadc7) chore: migrate to eslint-config-webpack ([#78](https://redirect.github.com/webpack/loader-runner/issues/78))
* [`a3f7282`](webpack/loader-runner@a3f7282) Merge pull request [#76](https://redirect.github.com/webpack/loader-runner/issues/76) from webpack/dependabot/npm\_and\_yarn/es5-ext-0.10.63
* [`db82227`](webpack/loader-runner@db82227) Bump es5-ext from 0.10.53 to 0.10.63
* [`7a94e9b`](webpack/loader-runner@7a94e9b) Merge pull request [#73](https://redirect.github.com/webpack/loader-runner/issues/73) from webpack/dependabot/npm\_and\_yarn/handlebars-4.7.8
* Additional commits viewable in [compare view](webpack/loader-runner@v4.3.0...v4.3.1)

Maintainer changes

This version was pushed to npm by [evilebottnawi](https://www.npmjs.com/~evilebottnawi), a new releaser for loader-runner since your current version.

  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=loader-runner&package-manager=npm\_and\_yarn&previous-version=4.3.0&new-version=4.3.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
mergify bot added a commit that referenced this pull request Dec 21, 2025
…2.2 to 1.2.3 in /studio [skip ci]

Bumps [update-browserslist-db](https://github.com/browserslist/update-db) from 1.2.2 to 1.2.3.
Release notes

*Sourced from [update-browserslist-db's releases](https://github.com/browserslist/update-db/releases).*

> 1.2.3
> -----
>
> * Fixed bun support (by [`@​cehenriques`](https://github.com/cehenriques)).


Changelog

*Sourced from [update-browserslist-db's changelog](https://github.com/browserslist/update-db/blob/main/CHANGELOG.md).*

> 1.2.3
> -----
>
> * Fixed bun support (by [`@​cehenriques`](https://github.com/cehenriques)).


Commits

* [`dc84ee9`](browserslist/update-db@dc84ee9) Release 1.2.3 version
* [`f70b5a5`](browserslist/update-db@f70b5a5) Update dependencies
* [`a5637ba`](browserslist/update-db@a5637ba) Merge pull request [#78](https://redirect.github.com/browserslist/update-db/issues/78) from cehenriques/main
* [`6876ea7`](browserslist/update-db@6876ea7) Support Bun info ([#77](https://redirect.github.com/browserslist/update-db/issues/77))
* See full diff in [compare view](browserslist/update-db@1.2.2...1.2.3)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=update-browserslist-db&package-manager=npm\_and\_yarn&previous-version=1.2.2&new-version=1.2.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests to SQL

3 participants