Skip to content

Add vector graph build diagnostics logging#3305

Merged
lvca merged 3 commits intoArcadeData:mainfrom
humemai:add-vector-graph-build-diagnostics
Feb 2, 2026
Merged

Add vector graph build diagnostics logging#3305
lvca merged 3 commits intoArcadeData:mainfrom
humemai:add-vector-graph-build-diagnostics

Conversation

@tae898
Copy link
Contributor

@tae898 tae898 commented Feb 1, 2026

I mocked what's done in https://github.com/datastax/jvector/blob/fe3f4d17a39a07b45a99403a615d8e65e9ddf8bf/jvector-examples/src/main/java/io/github/jbellis/jvector/example/benchmarks/QueryTester.java#L84 so that in arcadedb vector building we also get stats like

2026-02-01 19:10:41.421 INFO  [LSMVectorIndex] Graph build building: 957196/998480 (vector accesses=957200, heap=2121.0/4096.0MB, offheap=0.0MB, files=998.5MB [idx=998.5, graph=0.0, pq=0.0, compacted=0.0])
2026-02-01 19:10:43.444 INFO  [LSMVectorIndex] Graph build building: 957536/998480 (vector accesses=957540, heap=3125.0/4096.0MB, offheap=0.0MB, files=998.5MB [idx=998.5, graph=0.0, pq=0.0, compacted=0.0])
2026-02-01 19:10:45.464 INFO  [LSMVectorIndex] Graph build building: 957868/998480 (vector accesses=957872, heap=2630.0/4096.0MB, offheap=0.0MB, files=998.5MB [idx=998.5, graph=0.0, pq=0.0, compacted=0.0])
2026-02-01 19:10:47.491 INFO  [LSMVectorIndex] Graph build building: 958182/998480 (vector accesses=958186, heap=3229.0/4096.0MB, offheap=0.0MB, files=998.5MB [idx=998.5, graph=0.0, pq=0.0, compacted=0.0])
2026-02-01 19:10:49.583 INFO  [LSMVectorIndex] Graph build building: 958497/998480 (vector accesses=958501, heap=2602.0/4096.0MB, offheap=0.0MB, files=998.5MB [idx=998.5, graph=0.0, pq=0.0, compacted=0.0])
2026-02-01 19:10:51.639 INFO  [LSMVectorIndex] Graph build building: 958824/998480 (vector accesses=958828, heap=2322.0/4096.0MB, offheap=0.0MB, files=998.5MB [idx=998.5, graph=0.0, pq=0.0, compacted=0.0])

@tae898
Copy link
Contributor Author

tae898 commented Feb 1, 2026

@lvca

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 1, 2026

Summary of Changes

Hello @tae898, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the observability of the vector graph building process by integrating detailed diagnostic logging. It provides insights into memory consumption (heap and off-heap) and the size of various index-related files, which is crucial for performance analysis, benchmarking, and troubleshooting during vector index creation.

Highlights

  • New Configuration for Diagnostic Logging: A new global configuration setting, VECTOR_INDEX_GRAPH_BUILD_DIAGNOSTICS, has been introduced. This boolean flag controls whether detailed diagnostic logging is enabled during the vector graph build process, defaulting to true.
  • Enhanced Vector Graph Build Diagnostics: The LSMVectorIndex now includes functionality to capture and log comprehensive diagnostic information during graph building. This includes current heap memory usage (used/max), off-heap memory usage (direct and mapped buffers), and a breakdown of file sizes for the vector index, graph, PQ, and compacted files.
  • Conditional Logging: The progress logging for vector graph builds has been updated to conditionally include these new diagnostic details. If VECTOR_INDEX_GRAPH_BUILD_DIAGNOSTICS is enabled, the log messages will show memory and file size statistics; otherwise, they will revert to the previous, simpler format.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2026 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 763997c.

🟢 All jobs passed!

But CI Insights is watching 👀

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 1, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces diagnostic logging for vector graph builds, which is a useful feature for troubleshooting and performance tuning. The implementation is straightforward, adding a new configuration flag and capturing memory and file size metrics during the build process. My review includes two suggestions: one to change the default value of the new configuration flag to be off by default in production, and another to simplify a utility method for better code quality.

tae898
tae898 commented Feb 2, 2026
View reviewed changes
engine/src/main/java/com/arcadedb/index/vector/LSMVectorIndex.java
final long now = System.currentTimeMillis();
final boolean progressed = processedNodes != lastLoggedProcessed[0];
final boolean timeElapsed = now - lastLogTimeMs[0] >= 2000;
final boolean timeElapsed = now - lastLogTimeMs[0] >= 5000;
Copy link
Contributor Author

@tae898 tae898 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2s was too much.

@lvca lvca added this to the 26.2.1 milestone Feb 2, 2026
@lvca lvca merged commit 9202492 into ArcadeData:main Feb 2, 2026
15 of 18 checks passed
robfrank pushed a commit that referenced this pull request Feb 17, 2026
@tae898 @robfrank
Add vector graph build diagnostics logging (#3305)
e27e1ad 
* Add vector graph build diagnostics logging

* Tweak graph build diagnostics defaults

* Throttle graph build logs to 5s

(cherry picked from commit 9202492)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lvca lvca lvca approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tae898 tae898

Labels

None yet

Projects

None yet

Milestone

26.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@tae898 @lvca