Replace System.out.println with LogManager in LSMVectorIndex by Copilot · Pull Request #2912 · ArcadeData/arcadedb

Copilot · 2025-12-11T15:47:37Z

What does this PR do?

Replaces direct console output with proper logging infrastructure in LSMVectorIndex.loadVectorsFromPages().

Motivation

Addresses code review feedback from #2911. Direct use of System.out.println in library code bypasses log level controls and output routing. The codebase uses LogManager consistently elsewhere.

Related issues

Parent PR: perf: improved compression with lsm vectors #2911

Additional Notes

Changed from string concatenation to format specifiers for cleaner logging:

// Before
System.out.println("loadVectorsFromPages DONE: Loaded " + vectorIndex.size() + " vector locations (" + entriesRead
    + " total entries) for index: " + indexName + ", nextId=" + nextId.get() + "...");

// After  
LogManager.instance().log(this, Level.INFO, "loadVectorsFromPages DONE: Loaded %d vector locations (%d total entries) for index: %s, nextId=%d, fileId=%d, totalPages=%d%s",
    vectorIndex.size(), entriesRead, indexName, nextId.get(), getFileId(), getTotalPages(), ...);

Checklist

I have run the build using mvn clean package command
My unit tests cover both failure and success scenarios

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

each entry is not 17 bytes anymore, but variable. Also got rid of page header, because LSM are immutable only. Pointers are now absolute pointers.

Co-authored-by: lvca <312606+lvca@users.noreply.github.com>

Copilot · 2025-12-11T16:00:08Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

repository.apache.org
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/boot/plexus-classworlds-2.8.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1 -Dlibrary.jansi.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/arcadedb/arcadedb org.codehaus.plexus.classworlds.launcher.Launcher -f pom.xml -B -V -e -Dfindbugs.skip -Dcheckstyle.skip -Dpmd.skip=true -Dspotbugs.skip -Denforcer.skip -Dmaven.javadoc.skip -DskipTests (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

mergify · 2025-12-14T17:22:01Z

🧪 CI Insights

Here's what we observed from your CI run for d335d25.

🟢 All jobs passed!

But CI Insights is watching 👀

…in /studio in the security-critical group [skip ci] Bumps the security-critical group in /studio with 1 update: [sweetalert2](https://github.com/sweetalert2/sweetalert2). Updates `sweetalert2` from 11.26.17 to 11.26.18 Release notes *Sourced from [sweetalert2's releases](https://github.com/sweetalert2/sweetalert2/releases).* > v11.26.18 > --------- > > [11.26.18](sweetalert2/sweetalert2@v11.26.17...v11.26.18) (2026-02-02) > ------------------------------------------------------------------------------------------------- > > ### Bug Fixes > > * types in argsToParams.js ([#2912](https://redirect.github.com/sweetalert2/sweetalert2/issues/2912)) ([11e6344](sweetalert2/sweetalert2@11e6344)) Changelog *Sourced from [sweetalert2's changelog](https://github.com/sweetalert2/sweetalert2/blob/main/CHANGELOG.md).* > [11.26.18](sweetalert2/sweetalert2@v11.26.17...v11.26.18) (2026-02-02) > ------------------------------------------------------------------------------------------------- > > ### Bug Fixes > > * types in argsToParams.js ([#2912](https://redirect.github.com/sweetalert2/sweetalert2/issues/2912)) ([11e6344](sweetalert2/sweetalert2@11e6344)) Commits * [`01f6d80`](sweetalert2/sweetalert2@01f6d80) chore(release): 11.26.18 [skip ci] * [`11e6344`](sweetalert2/sweetalert2@11e6344) fix: types in argsToParams.js ([#2912](https://redirect.github.com/sweetalert2/sweetalert2/issues/2912)) * [`4866232`](sweetalert2/sweetalert2@4866232) chore: bump bun.lock * [`c640b87`](sweetalert2/sweetalert2@c640b87) chore: add PalsToy to sponsors * [`b995377`](sweetalert2/sweetalert2@b995377) chore: bump stylelint deps * [`c4a9734`](sweetalert2/sweetalert2@c4a9734) chore: bump bun.lock * [`c212154`](sweetalert2/sweetalert2@c212154) chore: rm dollauthority from sponsors * [`49c3c10`](sweetalert2/sweetalert2@49c3c10) chore: bump bun.lock * [`84317f0`](sweetalert2/sweetalert2@84317f0) chore: rm dlxplugins from sponsors * [`9ac3b97`](sweetalert2/sweetalert2@9ac3b97) chore: rm unnecessary code * Additional commits viewable in [compare view](sweetalert2/sweetalert2@v11.26.17...v11.26.18) [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=sweetalert2&package-manager=npm\_and\_yarn&previous-version=11.26.17&new-version=11.26.18)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore ` will remove the ignore condition of the specified dependency and ignore conditions

lvca and others added 2 commits December 11, 2025 10:41

perf: improved compression with lsm vectors

3c6303c

each entry is not 17 bytes anymore, but variable. Also got rid of page header, because LSM are immutable only. Pointers are now absolute pointers.

Initial plan

653c55c

Copilot AI assigned Copilot and lvca Dec 11, 2025

Copilot AI mentioned this pull request Dec 11, 2025

perf: improved compression with lsm vectors #2911

Merged

2 tasks

Copilot started work on behalf of lvca December 11, 2025 15:48 View session

Base automatically changed from lsm-vector-ultra-compressed to main December 11, 2025 15:49

Replace System.out.println with LogManager logging in LSMVectorIndex

d335d25

Co-authored-by: lvca <312606+lvca@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Address feedback on improved compression with lsm vectors~~ Replace System.out.println with LogManager in LSMVectorIndex Dec 11, 2025

Copilot AI requested a review from lvca December 11, 2025 16:00

Copilot finished work on behalf of lvca December 11, 2025 16:00

robfrank closed this Jan 16, 2026

robfrank deleted the copilot/sub-pr-2911 branch January 16, 2026 20:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Replace System.out.println with LogManager in LSMVectorIndex#2912

Replace System.out.println with LogManager in LSMVectorIndex#2912
Copilot wants to merge 3 commits intomainfrom
copilot/sub-pr-2911

Copilot AI commented Dec 11, 2025 •

edited

Loading

Uh oh!

Copilot AI commented Dec 11, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

mergify bot commented Dec 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Copilot AI commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Related issues

Additional Notes

Checklist

Uh oh!

Copilot AI commented Dec 11, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

mergify bot commented Dec 14, 2025

🧪 CI Insights

🟢 All jobs passed!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Dec 11, 2025 •

edited

Loading