Skip to content

Fix more restore log entries#2732

Merged
lvca merged 1 commit intoArcadeData:mainfrom
gramian:main
Nov 3, 2025
Merged

Fix more restore log entries#2732
lvca merged 1 commit intoArcadeData:mainfrom
gramian:main

Conversation

@gramian
Copy link
Collaborator

@gramian gramian commented Nov 3, 2025

What does this PR do?

This change continues #2723 in that for intermediate entries also the sequence is corrected wrt to uncompressing.

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 3, 2025

Summary of Changes

Hello @gramian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the logging mechanism within the restore process by correcting the order and terminology used when reporting file compression details. The change ensures that log entries accurately represent the compressed and original file sizes, thereby improving the clarity and correctness of the restore operation's output.

Highlights

  • Logging Correction: Corrected the sequence of logged information for intermediate entries during file uncompression, specifically ensuring the compressed size is displayed before the original size in the log message.
  • Clarity Improvement: Updated the log message from 'compressed' to 'compression' to accurately reflect the percentage calculation, enhancing readability and precision in restore logs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects the order of arguments in a log message for file uncompression to show compressed size -> original size, which is more intuitive. The wording is also improved from 'compressed' to 'compression'. I've added one suggestion to handle an edge case where the compressed file size might not be known, which would lead to an incorrect compression percentage being logged.

@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 7869ed7.

🟢 All jobs passed!

But CI Insights is watching 👀

@lvca lvca merged commit b2b937e into ArcadeData:main Nov 3, 2025
11 of 13 checks passed
@lvca lvca added this to the 25.10.1 milestone Nov 3, 2025
robfrank pushed a commit that referenced this pull request Nov 10, 2025
@gramian @robfrank
Fix more restore log entries (#2732)
d21501a 
(cherry picked from commit b2b937e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lvca lvca lvca approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@gramian gramian

Labels

None yet

Projects

None yet

Milestone

25.10.1

Development

Successfully merging this pull request may close these issues.

2 participants

@gramian @lvca