Revert "Add arguments to server and console script to prevent warnings"#2699
Revert "Add arguments to server and console script to prevent warnings"#2699
Conversation
Summary of ChangesHello @robfrank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a direct revert of a previous change (PR #2698) that introduced specific JVM arguments to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🧪 CI InsightsHere's what we observed from your CI run for c3a5675. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Code Review
This pull request reverts changes that added specific JVM arguments to the server.sh and console.sh startup scripts. While the changes in server.sh appear to be a clean revert, the console.sh script introduces a new --illegal-access=deny flag. My review focuses on the potential issues this new flag can cause, particularly with newer JDK versions, and the inconsistency it creates with the Windows startup script. I have suggested removing this flag to align with the intent of the revert.
| -Dfile.encoding=UTF8 \ | ||
| --illegal-access=deny" |
There was a problem hiding this comment.
The addition of --illegal-access=deny is concerning. This flag is not recognized in JDK 17 and later, and will cause the JVM to fail to start. For JDK 9-15, it changes the default behavior which might cause unexpected IllegalAccessException if the application or its dependencies rely on reflective access to internal APIs.
Since this PR is a revert, it seems this line may have been added unintentionally. The corresponding console.bat file does not include this flag, leading to an inconsistency between platforms.
To make this a clean revert and maintain consistency, I suggest removing the added flag.
| -Dfile.encoding=UTF8 \ | |
| --illegal-access=deny" | |
| -Dfile.encoding=UTF8" |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Reverts #2698