Refactor: Merge JSON serializer implementations into unified JsonSerializer#2577
Merged
Merged
Conversation
… usages Co-authored-by: robfrank <413587+robfrank@users.noreply.github.com>
Co-authored-by: robfrank <413587+robfrank@users.noreply.github.com>
Co-authored-by: robfrank <413587+robfrank@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactoring: merge 2 JSON serializer implementations
Refactor: Merge JSON serializer implementations into unified JsonSerializer
Sep 28, 2025
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates two duplicate JSON serialization implementations that were serving different parts of the codebase:
com.arcadedb.serializer.JsonSerializer- Used by HTTP handlers and query processingcom.arcadedb.database.JSONSerializer- Used by document classes for JSON serializationProblem
Having two separate JSON serializers created maintenance overhead and potential inconsistencies:
Solution
Enhanced
JsonSerializerto include all functionality fromJSONSerializer, then updated all usages across the codebase:Enhanced JsonSerializer with:
map2json()method with property filtering and metadata supportjson2map()method for JSON-to-map conversionconvertToJSONType,convertFromJSONType)Updated classes:
BaseDocument,MutableDocument,ImmutableDocument,DetachedDocumentRemoteImmutableDocument,RemoteMutableDocument, etc.Removed:
com.arcadedb.database.JSONSerializerclassBenefits
All existing functionality is preserved, and the change is completely transparent to consumers of the JSON serialization APIs.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.