[Helm] ArcadeDB chart has serverList hardcoded not allowing multiple replicas#2325
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @carlos-rodrigues-8x8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the ArcadeDB Helm chart by resolving a limitation that prevented the deployment of multiple replicas. It introduces templating logic to dynamically generate the high-availability server list based on the configured replica count, thereby improving the chart's scalability and support for clustered deployments.
Highlights
- Multi-replica support: I've addressed an issue where the
arcadedb.ha.serverListwas hardcoded in the Helm chart, preventing the deployment of multiple ArcadeDB replicas. This change enables the chart to dynamically generate the server list based on thereplicaCount. - New Helm helpers: I've introduced two new helper templates in
_helpers.tpl:arcadedb.k8sSuffixto generate the Kubernetes service suffix, andarcadedb.nodenamesto construct a comma-separated list of pod names for theserverList. - StatefulSet configuration update: The
statefulset.yamlhas been updated to utilize the newly created Helm helpers forarcadedb.ha.serverListandarcadedb.ha.k8sSuffix, ensuring the dynamic generation of these values.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request modifies the ArcadeDB Helm chart to support multiple replicas by dynamically generating the arcadedb.ha.serverList based on replicaCount. It introduces new helper templates for this purpose. A key improvement is also the correction of the Kubernetes service suffix used for pod DNS names, which now correctly uses the application's full name instead of the chart name. The review includes suggestions to refine the new helper templates by following Helm templating best practices for cleaner and more maintainable code.
|
LGTM to me, merging (Thanks!) |
What does this PR do?
This PR is meant to fix the
arcadedb.ha.serverListwhich is hardcoded and doesn't allow to add multiple replicas on same cluster.Motivation
Contributing for evolving this open-source project
Related issues
#2324
Additional Notes
For testing the generated manifests:
The result must be a
arcadedb.ha.serverListwith 3 nodes.Checklist
mvn clean packagecommand