Skip to content

feat: awaitRespsonse for HTTP command#1326

Merged
lvca merged 4 commits intoArcadeData:mainfrom
gramian:main
Nov 16, 2023
Merged

feat: awaitRespsonse for HTTP command#1326
lvca merged 4 commits intoArcadeData:mainfrom
gramian:main

Conversation

@gramian
Copy link
Collaborator

@gramian gramian commented Nov 15, 2023

What does this PR do?

This change adds an optional field awaitResponse to the body of a HTTP API command endpoint request, that , if false, executes the payload command asynchronously.

@lvca This is a work-in-progress. Could you please carefully review this change in terms of if this is the correct approach and style for asynchronous commands. Please feel free to make changes yourself.

  • Still missing are callbacks, logging a completed command to the log.

Related issues

#1323

Additional Notes

I will do a more extensive refactoring of this class once functionality is complete, particularly duplication and conditionals.

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca
Copy link
Contributor

lvca commented Nov 15, 2023

I think this is great. I'd approve it as is, unless you want to make some changes.

@lvca lvca self-requested a review November 15, 2023 22:41
@lvca lvca added the enhancement New feature or request label Nov 15, 2023
@lvca lvca added this to the 23.11.1 milestone Nov 15, 2023
@gramian
Copy link
Collaborator Author

gramian commented Nov 15, 2023

Cool. Manually testing it, it seems to work.

One thing I haven't figured out yet is how to INFO level log from a DatabaseAsyncCallback, so I can note a succesful completion of an async command in the log. Furthermore I want to refactor this class a bit, if you don't mind.

@lvca
Copy link
Contributor

lvca commented Nov 15, 2023

ok for the refactoring. You can pass a callback to the task, so when the operation succeeds something is executed, like a log for debug purposes.

@gramian
Copy link
Collaborator Author

gramian commented Nov 16, 2023

I only need to do at least some more manual testing.

@lvca
Copy link
Contributor

lvca commented Nov 16, 2023

To write a test case for it, you can clone from this test:

public void checkCommandNoDuplication() throws Exception {

Also, I was thinking that now the RemoteDatabase class could support a minimal version of async() like with EmbeddedDatabase, where it fires HTTP commands with the flag awaitResponse equals to false.

Something like:

database.async().command("sql", "delete from SensorData where date < Date('2023-01-01')");

WDYT?

@gramian
Copy link
Collaborator Author

gramian commented Nov 16, 2023

I added a passing IT test. From my point of view it is ready now.

@gramian gramian changed the title [WIP] feat: awaitRespsonse for HTTP command feat: awaitRespsonse for HTTP command Nov 16, 2023
@lvca lvca merged commit 3181b75 into ArcadeData:main Nov 16, 2023
@lvca
Copy link
Contributor

lvca commented Nov 16, 2023

Perfect, thanks

mergify bot added a commit that referenced this pull request Aug 10, 2025
Bumps `jline.version` from 3.30.4 to 3.30.5.
Updates `org.jline:jline-terminal` from 3.30.4 to 3.30.5
Release notes

*Sourced from [org.jline:jline-terminal's releases](https://github.com/jline/jline3/releases).*

> 3.30.5
> ------
>
> 🚀 New features and improvements
> -------------------------------
>
> * Improve console variable expansion (fixes [#1370](https://redirect.github.com/jline/jline3/issues/1370)) ([#1371](https://redirect.github.com/jline/jline3/pull/1371)) [`@​paulk-asert`](https://github.com/paulk-asert)
> * ConsoleEngineImpl: change method and field visibilities ([#1357](https://redirect.github.com/jline/jline3/pull/1357)) [`@​mattirn`](https://github.com/mattirn)
> * Allow ConsoleEngineImpl subclasses access to VariableReferenceCompleter ([#1362](https://redirect.github.com/jline/jline3/pull/1362)) [`@​paulk-asert`](https://github.com/paulk-asert)
> * feat: add reusable POSIX commands to builtins module ([#1341](https://redirect.github.com/jline/jline3/pull/1341)) [`@​gnodet`](https://github.com/gnodet)
> * feat: support slurp command to be renamed ([#1333](https://redirect.github.com/jline/jline3/pull/1333)) [`@​paulk-asert`](https://github.com/paulk-asert)
> * feat: Extend InputRC with method/s to directly read ~/.inputrc & /etc/inputrc ([#1297](https://redirect.github.com/jline/jline3/pull/1297)) [`@​vorburger`](https://github.com/vorburger)
> * Allow system commands to be renamed. ([#1334](https://redirect.github.com/jline/jline3/pull/1334)) [`@​paulk-asert`](https://github.com/paulk-asert)
>
> 🐛 Bug Fixes
> -----------
>
> * Fix macOS hang in pipe operations by removing PTY terminal usage ([#1382](https://redirect.github.com/jline/jline3/pull/1382)) [`@​gnodet`](https://github.com/gnodet)
> * enhancement: only compute suggestions in the Nano editor if something… ([#1327](https://redirect.github.com/jline/jline3/pull/1327)) [`@​johnpoth`](https://github.com/johnpoth)
> * fix: refactor TerminalProvider methods to use inputEncoding/outputEncoding parameters ([#1319](https://redirect.github.com/jline/jline3/pull/1319)) [`@​gnodet`](https://github.com/gnodet)
> * Fix System.out not working after closing dumb terminal ([#1337](https://redirect.github.com/jline/jline3/pull/1337)) [`@​gnodet`](https://github.com/gnodet)
>
> 📦 Dependency updates
> --------------------
>
> * chore: Bump com.diffplug.spotless:spotless-maven-plugin from 2.45.0 to 2.46.1 ([#1364](https://redirect.github.com/jline/jline3/pull/1364)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump groovy.version from 4.0.27 to 4.0.28 ([#1365](https://redirect.github.com/jline/jline3/pull/1365)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.palantir.javaformat:palantir-java-format from 2.72.0 to 2.73.0 ([#1369](https://redirect.github.com/jline/jline3/pull/1369)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump junit.version from 5.13.3 to 5.13.4 ([#1363](https://redirect.github.com/jline/jline3/pull/1363)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.palantir.javaformat:palantir-java-format from 2.71.0 to 2.72.0 ([#1359](https://redirect.github.com/jline/jline3/pull/1359)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.palantir.javaformat:palantir-java-format from 2.70.0 to 2.71.0 ([#1354](https://redirect.github.com/jline/jline3/pull/1354)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.graalvm.sdk:graal-sdk from 24.2.1 to 24.2.2 ([#1352](https://redirect.github.com/jline/jline3/pull/1352)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.google.jimfs:jimfs from 1.3.0 to 1.3.1 ([#1351](https://redirect.github.com/jline/jline3/pull/1351)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.6.0 to 3.6.1 ([#1355](https://redirect.github.com/jline/jline3/pull/1355)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump on-headers and compression in /website ([#1356](https://redirect.github.com/jline/jline3/pull/1356)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.5 to 2.45.0 ([#1347](https://redirect.github.com/jline/jline3/pull/1347)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.codehaus.gmavenplus:gmavenplus-plugin from 4.2.0 to 4.2.1 ([#1346](https://redirect.github.com/jline/jline3/pull/1346)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.palantir.javaformat:palantir-java-format from 2.67.0 to 2.70.0 ([#1342](https://redirect.github.com/jline/jline3/pull/1342)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump junit.version from 5.13.0 to 5.13.3 ([#1343](https://redirect.github.com/jline/jline3/pull/1343)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.apache.maven.plugins:maven-clean-plugin from 3.4.1 to 3.5.0 ([#1322](https://redirect.github.com/jline/jline3/pull/1322)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.4 to 2.44.5 ([#1315](https://redirect.github.com/jline/jline3/pull/1315)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.codehaus.mojo:build-helper-maven-plugin from 3.6.0 to 3.6.1 ([#1326](https://redirect.github.com/jline/jline3/pull/1326)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.7 to 3.2.8 ([#1339](https://redirect.github.com/jline/jline3/pull/1339)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.5.0 to 3.6.0 ([#1340](https://redirect.github.com/jline/jline3/pull/1340)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump junit.version from 5.12.2 to 5.13.0 ([#1321](https://redirect.github.com/jline/jline3/pull/1321)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump eu.maveniverse.maven.njord:extension from 0.6.2 to 0.7.5 ([#1330](https://redirect.github.com/jline/jline3/pull/1330)) @[dependabot[bot]](https://github.com/apps/dependabot)
>
> 📝 Documentation updates
> -----------------------
>
> * docs: Link to Nano Customization from Builtins doc page ([#1312](https://redirect.github.com/jline/jline3/pull/1312)) [`@​vorburger`](https://github.com/vorburger)
> * docs: Add Capability.enter\_ca\_mode and Capability.exit\_ca\_mode tip ([#1311](https://redirect.github.com/jline/jline3/pull/1311)) [`@​vorburger`](https://github.com/vorburger)
> * Remove double `docs/docs` in edit links on jline.org (fixes [#1309](https://redirect.github.com/jline/jline3/issues/1309)) ([#1310](https://redirect.github.com/jline/jline3/pull/1310)) [`@​vorburger`](https://github.com/vorburger)
> * Update intro.md ([#1332](https://redirect.github.com/jline/jline3/pull/1332)) [`@​paulk-asert`](https://github.com/paulk-asert)

... (truncated)


Commits

* [`b91a3b3`](jline/jline3@b91a3b3) Zero-commit release process ([#1335](https://redirect.github.com/jline/jline3/issues/1335))
* [`e2422d7`](jline/jline3@e2422d7) [maven-release-plugin] prepare for next development iteration
* [`ae95742`](jline/jline3@ae95742) [maven-release-plugin] prepare release jline-3.30.5
* [`87bf8b3`](jline/jline3@87bf8b3) Fix macOS hang in pipe operations by removing PTY terminal usage ([#1382](https://redirect.github.com/jline/jline3/issues/1382))
* [`0ee349c`](jline/jline3@0ee349c) provide smarter arg parsing [#1370](https://redirect.github.com/jline/jline3/issues/1370) ([#1371](https://redirect.github.com/jline/jline3/issues/1371))
* [`0088a70`](jline/jline3@0088a70) ConsoleEngineImpl: change method and field visibilities ([#1357](https://redirect.github.com/jline/jline3/issues/1357))
* [`6152f8b`](jline/jline3@6152f8b) Allow ConsoleEngineImpl subclasses access to VariableReferenceCompleter ([#1362](https://redirect.github.com/jline/jline3/issues/1362))
* [`aafaf9c`](jline/jline3@aafaf9c) chore: Bump com.diffplug.spotless:spotless-maven-plugin ([#1364](https://redirect.github.com/jline/jline3/issues/1364))
* [`ba9f347`](jline/jline3@ba9f347) chore: Bump groovy.version from 4.0.27 to 4.0.28 ([#1365](https://redirect.github.com/jline/jline3/issues/1365))
* [`e085017`](jline/jline3@e085017) chore: Bump com.palantir.javaformat:palantir-java-format ([#1369](https://redirect.github.com/jline/jline3/issues/1369))
* Additional commits viewable in [compare view](jline/jline3@jline-3.30.4...3.30.5)
  
Updates `org.jline:jline-reader` from 3.30.4 to 3.30.5
Release notes

*Sourced from [org.jline:jline-reader's releases](https://github.com/jline/jline3/releases).*

> 3.30.5
> ------
>
> 🚀 New features and improvements
> -------------------------------
>
> * Improve console variable expansion (fixes [#1370](https://redirect.github.com/jline/jline3/issues/1370)) ([#1371](https://redirect.github.com/jline/jline3/pull/1371)) [`@​paulk-asert`](https://github.com/paulk-asert)
> * ConsoleEngineImpl: change method and field visibilities ([#1357](https://redirect.github.com/jline/jline3/pull/1357)) [`@​mattirn`](https://github.com/mattirn)
> * Allow ConsoleEngineImpl subclasses access to VariableReferenceCompleter ([#1362](https://redirect.github.com/jline/jline3/pull/1362)) [`@​paulk-asert`](https://github.com/paulk-asert)
> * feat: add reusable POSIX commands to builtins module ([#1341](https://redirect.github.com/jline/jline3/pull/1341)) [`@​gnodet`](https://github.com/gnodet)
> * feat: support slurp command to be renamed ([#1333](https://redirect.github.com/jline/jline3/pull/1333)) [`@​paulk-asert`](https://github.com/paulk-asert)
> * feat: Extend InputRC with method/s to directly read ~/.inputrc & /etc/inputrc ([#1297](https://redirect.github.com/jline/jline3/pull/1297)) [`@​vorburger`](https://github.com/vorburger)
> * Allow system commands to be renamed. ([#1334](https://redirect.github.com/jline/jline3/pull/1334)) [`@​paulk-asert`](https://github.com/paulk-asert)
>
> 🐛 Bug Fixes
> -----------
>
> * Fix macOS hang in pipe operations by removing PTY terminal usage ([#1382](https://redirect.github.com/jline/jline3/pull/1382)) [`@​gnodet`](https://github.com/gnodet)
> * enhancement: only compute suggestions in the Nano editor if something… ([#1327](https://redirect.github.com/jline/jline3/pull/1327)) [`@​johnpoth`](https://github.com/johnpoth)
> * fix: refactor TerminalProvider methods to use inputEncoding/outputEncoding parameters ([#1319](https://redirect.github.com/jline/jline3/pull/1319)) [`@​gnodet`](https://github.com/gnodet)
> * Fix System.out not working after closing dumb terminal ([#1337](https://redirect.github.com/jline/jline3/pull/1337)) [`@​gnodet`](https://github.com/gnodet)
>
> 📦 Dependency updates
> --------------------
>
> * chore: Bump com.diffplug.spotless:spotless-maven-plugin from 2.45.0 to 2.46.1 ([#1364](https://redirect.github.com/jline/jline3/pull/1364)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump groovy.version from 4.0.27 to 4.0.28 ([#1365](https://redirect.github.com/jline/jline3/pull/1365)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.palantir.javaformat:palantir-java-format from 2.72.0 to 2.73.0 ([#1369](https://redirect.github.com/jline/jline3/pull/1369)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump junit.version from 5.13.3 to 5.13.4 ([#1363](https://redirect.github.com/jline/jline3/pull/1363)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.palantir.javaformat:palantir-java-format from 2.71.0 to 2.72.0 ([#1359](https://redirect.github.com/jline/jline3/pull/1359)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.palantir.javaformat:palantir-java-format from 2.70.0 to 2.71.0 ([#1354](https://redirect.github.com/jline/jline3/pull/1354)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.graalvm.sdk:graal-sdk from 24.2.1 to 24.2.2 ([#1352](https://redirect.github.com/jline/jline3/pull/1352)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.google.jimfs:jimfs from 1.3.0 to 1.3.1 ([#1351](https://redirect.github.com/jline/jline3/pull/1351)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.6.0 to 3.6.1 ([#1355](https://redirect.github.com/jline/jline3/pull/1355)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump on-headers and compression in /website ([#1356](https://redirect.github.com/jline/jline3/pull/1356)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.5 to 2.45.0 ([#1347](https://redirect.github.com/jline/jline3/pull/1347)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.codehaus.gmavenplus:gmavenplus-plugin from 4.2.0 to 4.2.1 ([#1346](https://redirect.github.com/jline/jline3/pull/1346)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.palantir.javaformat:palantir-java-format from 2.67.0 to 2.70.0 ([#1342](https://redirect.github.com/jline/jline3/pull/1342)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump junit.version from 5.13.0 to 5.13.3 ([#1343](https://redirect.github.com/jline/jline3/pull/1343)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.apache.maven.plugins:maven-clean-plugin from 3.4.1 to 3.5.0 ([#1322](https://redirect.github.com/jline/jline3/pull/1322)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.4 to 2.44.5 ([#1315](https://redirect.github.com/jline/jline3/pull/1315)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.codehaus.mojo:build-helper-maven-plugin from 3.6.0 to 3.6.1 ([#1326](https://redirect.github.com/jline/jline3/pull/1326)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.7 to 3.2.8 ([#1339](https://redirect.github.com/jline/jline3/pull/1339)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.5.0 to 3.6.0 ([#1340](https://redirect.github.com/jline/jline3/pull/1340)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump junit.version from 5.12.2 to 5.13.0 ([#1321](https://redirect.github.com/jline/jline3/pull/1321)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump eu.maveniverse.maven.njord:extension from 0.6.2 to 0.7.5 ([#1330](https://redirect.github.com/jline/jline3/pull/1330)) @[dependabot[bot]](https://github.com/apps/dependabot)
>
> 📝 Documentation updates
> -----------------------
>
> * docs: Link to Nano Customization from Builtins doc page ([#1312](https://redirect.github.com/jline/jline3/pull/1312)) [`@​vorburger`](https://github.com/vorburger)
> * docs: Add Capability.enter\_ca\_mode and Capability.exit\_ca\_mode tip ([#1311](https://redirect.github.com/jline/jline3/pull/1311)) [`@​vorburger`](https://github.com/vorburger)
> * Remove double `docs/docs` in edit links on jline.org (fixes [#1309](https://redirect.github.com/jline/jline3/issues/1309)) ([#1310](https://redirect.github.com/jline/jline3/pull/1310)) [`@​vorburger`](https://github.com/vorburger)
> * Update intro.md ([#1332](https://redirect.github.com/jline/jline3/pull/1332)) [`@​paulk-asert`](https://github.com/paulk-asert)

... (truncated)


Commits

* [`b91a3b3`](jline/jline3@b91a3b3) Zero-commit release process ([#1335](https://redirect.github.com/jline/jline3/issues/1335))
* [`e2422d7`](jline/jline3@e2422d7) [maven-release-plugin] prepare for next development iteration
* [`ae95742`](jline/jline3@ae95742) [maven-release-plugin] prepare release jline-3.30.5
* [`87bf8b3`](jline/jline3@87bf8b3) Fix macOS hang in pipe operations by removing PTY terminal usage ([#1382](https://redirect.github.com/jline/jline3/issues/1382))
* [`0ee349c`](jline/jline3@0ee349c) provide smarter arg parsing [#1370](https://redirect.github.com/jline/jline3/issues/1370) ([#1371](https://redirect.github.com/jline/jline3/issues/1371))
* [`0088a70`](jline/jline3@0088a70) ConsoleEngineImpl: change method and field visibilities ([#1357](https://redirect.github.com/jline/jline3/issues/1357))
* [`6152f8b`](jline/jline3@6152f8b) Allow ConsoleEngineImpl subclasses access to VariableReferenceCompleter ([#1362](https://redirect.github.com/jline/jline3/issues/1362))
* [`aafaf9c`](jline/jline3@aafaf9c) chore: Bump com.diffplug.spotless:spotless-maven-plugin ([#1364](https://redirect.github.com/jline/jline3/issues/1364))
* [`ba9f347`](jline/jline3@ba9f347) chore: Bump groovy.version from 4.0.27 to 4.0.28 ([#1365](https://redirect.github.com/jline/jline3/issues/1365))
* [`e085017`](jline/jline3@e085017) chore: Bump com.palantir.javaformat:palantir-java-format ([#1369](https://redirect.github.com/jline/jline3/issues/1369))
* Additional commits viewable in [compare view](jline/jline3@jline-3.30.4...3.30.5)
  
Updates `org.jline:jline-terminal-jni` from 3.30.4 to 3.30.5
Release notes

*Sourced from [org.jline:jline-terminal-jni's releases](https://github.com/jline/jline3/releases).*

> 3.30.5
> ------
>
> 🚀 New features and improvements
> -------------------------------
>
> * Improve console variable expansion (fixes [#1370](https://redirect.github.com/jline/jline3/issues/1370)) ([#1371](https://redirect.github.com/jline/jline3/pull/1371)) [`@​paulk-asert`](https://github.com/paulk-asert)
> * ConsoleEngineImpl: change method and field visibilities ([#1357](https://redirect.github.com/jline/jline3/pull/1357)) [`@​mattirn`](https://github.com/mattirn)
> * Allow ConsoleEngineImpl subclasses access to VariableReferenceCompleter ([#1362](https://redirect.github.com/jline/jline3/pull/1362)) [`@​paulk-asert`](https://github.com/paulk-asert)
> * feat: add reusable POSIX commands to builtins module ([#1341](https://redirect.github.com/jline/jline3/pull/1341)) [`@​gnodet`](https://github.com/gnodet)
> * feat: support slurp command to be renamed ([#1333](https://redirect.github.com/jline/jline3/pull/1333)) [`@​paulk-asert`](https://github.com/paulk-asert)
> * feat: Extend InputRC with method/s to directly read ~/.inputrc & /etc/inputrc ([#1297](https://redirect.github.com/jline/jline3/pull/1297)) [`@​vorburger`](https://github.com/vorburger)
> * Allow system commands to be renamed. ([#1334](https://redirect.github.com/jline/jline3/pull/1334)) [`@​paulk-asert`](https://github.com/paulk-asert)
>
> 🐛 Bug Fixes
> -----------
>
> * Fix macOS hang in pipe operations by removing PTY terminal usage ([#1382](https://redirect.github.com/jline/jline3/pull/1382)) [`@​gnodet`](https://github.com/gnodet)
> * enhancement: only compute suggestions in the Nano editor if something… ([#1327](https://redirect.github.com/jline/jline3/pull/1327)) [`@​johnpoth`](https://github.com/johnpoth)
> * fix: refactor TerminalProvider methods to use inputEncoding/outputEncoding parameters ([#1319](https://redirect.github.com/jline/jline3/pull/1319)) [`@​gnodet`](https://github.com/gnodet)
> * Fix System.out not working after closing dumb terminal ([#1337](https://redirect.github.com/jline/jline3/pull/1337)) [`@​gnodet`](https://github.com/gnodet)
>
> 📦 Dependency updates
> --------------------
>
> * chore: Bump com.diffplug.spotless:spotless-maven-plugin from 2.45.0 to 2.46.1 ([#1364](https://redirect.github.com/jline/jline3/pull/1364)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump groovy.version from 4.0.27 to 4.0.28 ([#1365](https://redirect.github.com/jline/jline3/pull/1365)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.palantir.javaformat:palantir-java-format from 2.72.0 to 2.73.0 ([#1369](https://redirect.github.com/jline/jline3/pull/1369)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump junit.version from 5.13.3 to 5.13.4 ([#1363](https://redirect.github.com/jline/jline3/pull/1363)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.palantir.javaformat:palantir-java-format from 2.71.0 to 2.72.0 ([#1359](https://redirect.github.com/jline/jline3/pull/1359)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.palantir.javaformat:palantir-java-format from 2.70.0 to 2.71.0 ([#1354](https://redirect.github.com/jline/jline3/pull/1354)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.graalvm.sdk:graal-sdk from 24.2.1 to 24.2.2 ([#1352](https://redirect.github.com/jline/jline3/pull/1352)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.google.jimfs:jimfs from 1.3.0 to 1.3.1 ([#1351](https://redirect.github.com/jline/jline3/pull/1351)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.6.0 to 3.6.1 ([#1355](https://redirect.github.com/jline/jline3/pull/1355)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump on-headers and compression in /website ([#1356](https://redirect.github.com/jline/jline3/pull/1356)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.5 to 2.45.0 ([#1347](https://redirect.github.com/jline/jline3/pull/1347)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.codehaus.gmavenplus:gmavenplus-plugin from 4.2.0 to 4.2.1 ([#1346](https://redirect.github.com/jline/jline3/pull/1346)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.palantir.javaformat:palantir-java-format from 2.67.0 to 2.70.0 ([#1342](https://redirect.github.com/jline/jline3/pull/1342)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump junit.version from 5.13.0 to 5.13.3 ([#1343](https://redirect.github.com/jline/jline3/pull/1343)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.apache.maven.plugins:maven-clean-plugin from 3.4.1 to 3.5.0 ([#1322](https://redirect.github.com/jline/jline3/pull/1322)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.4 to 2.44.5 ([#1315](https://redirect.github.com/jline/jline3/pull/1315)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.codehaus.mojo:build-helper-maven-plugin from 3.6.0 to 3.6.1 ([#1326](https://redirect.github.com/jline/jline3/pull/1326)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.7 to 3.2.8 ([#1339](https://redirect.github.com/jline/jline3/pull/1339)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.5.0 to 3.6.0 ([#1340](https://redirect.github.com/jline/jline3/pull/1340)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump junit.version from 5.12.2 to 5.13.0 ([#1321](https://redirect.github.com/jline/jline3/pull/1321)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump eu.maveniverse.maven.njord:extension from 0.6.2 to 0.7.5 ([#1330](https://redirect.github.com/jline/jline3/pull/1330)) @[dependabot[bot]](https://github.com/apps/dependabot)
>
> 📝 Documentation updates
> -----------------------
>
> * docs: Link to Nano Customization from Builtins doc page ([#1312](https://redirect.github.com/jline/jline3/pull/1312)) [`@​vorburger`](https://github.com/vorburger)
> * docs: Add Capability.enter\_ca\_mode and Capability.exit\_ca\_mode tip ([#1311](https://redirect.github.com/jline/jline3/pull/1311)) [`@​vorburger`](https://github.com/vorburger)
> * Remove double `docs/docs` in edit links on jline.org (fixes [#1309](https://redirect.github.com/jline/jline3/issues/1309)) ([#1310](https://redirect.github.com/jline/jline3/pull/1310)) [`@​vorburger`](https://github.com/vorburger)
> * Update intro.md ([#1332](https://redirect.github.com/jline/jline3/pull/1332)) [`@​paulk-asert`](https://github.com/paulk-asert)

... (truncated)


Commits

* [`b91a3b3`](jline/jline3@b91a3b3) Zero-commit release process ([#1335](https://redirect.github.com/jline/jline3/issues/1335))
* [`e2422d7`](jline/jline3@e2422d7) [maven-release-plugin] prepare for next development iteration
* [`ae95742`](jline/jline3@ae95742) [maven-release-plugin] prepare release jline-3.30.5
* [`87bf8b3`](jline/jline3@87bf8b3) Fix macOS hang in pipe operations by removing PTY terminal usage ([#1382](https://redirect.github.com/jline/jline3/issues/1382))
* [`0ee349c`](jline/jline3@0ee349c) provide smarter arg parsing [#1370](https://redirect.github.com/jline/jline3/issues/1370) ([#1371](https://redirect.github.com/jline/jline3/issues/1371))
* [`0088a70`](jline/jline3@0088a70) ConsoleEngineImpl: change method and field visibilities ([#1357](https://redirect.github.com/jline/jline3/issues/1357))
* [`6152f8b`](jline/jline3@6152f8b) Allow ConsoleEngineImpl subclasses access to VariableReferenceCompleter ([#1362](https://redirect.github.com/jline/jline3/issues/1362))
* [`aafaf9c`](jline/jline3@aafaf9c) chore: Bump com.diffplug.spotless:spotless-maven-plugin ([#1364](https://redirect.github.com/jline/jline3/issues/1364))
* [`ba9f347`](jline/jline3@ba9f347) chore: Bump groovy.version from 4.0.27 to 4.0.28 ([#1365](https://redirect.github.com/jline/jline3/issues/1365))
* [`e085017`](jline/jline3@e085017) chore: Bump com.palantir.javaformat:palantir-java-format ([#1369](https://redirect.github.com/jline/jline3/issues/1369))
* Additional commits viewable in [compare view](jline/jline3@jline-3.30.4...3.30.5)
  
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants