fix: out of text range while composing error#979
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
=======================================
Coverage 72.25% 72.25%
=======================================
Files 318 318
Lines 15132 15134 +2
=======================================
+ Hits 10933 10935 +2
Misses 4199 4199 ☔ View full report in Codecov by Sentry. |
Collaborator
|
@kyungilcho Your PR may fix the composing error, but I think the attached position is still incorrect. The position is empty if the assertion happens. |
Hai-Pi
pushed a commit
to Hai-Pi/appflowy-editor
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Screen_Recording_20241202-230013.mp4
Re-positioning the cursor in the middle of sentence while composing occurs following error.
so I add logic for checking validity of cursor position.