Merged
Conversation
…les are available and linked for non-autolinking scenarios (RN <= 0.59).
janicduplessis
approved these changes
Jan 27, 2021
Collaborator
janicduplessis
left a comment
There was a problem hiding this comment.
Thanks for fixing this! I'll keep that in mind when making changes. I'll see if I can think of a simple way to test this on CI too.
janicduplessis
pushed a commit
that referenced
this pull request
Mar 7, 2021
This was referenced Mar 8, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding all .h and .m files to the Xcode project to ensure that all files are available and linked for non-autolinking scenarios (RN <= 0.59).
This should fix #158.
Summary
I had an older RN project that was still on RN 0.59.10. When adding this project and linking (manually via
react-native link), the build failed. I noticed that not every file was included in the project. When manually fixing this, my build succeeded.Test Plan
As mentioned in the summary, I had a RN project on version 0.59.10. The build failed until I manually added the rest of the
.h. and.mfiles to the project. This makes the same change that fixed my build.Perhaps there should be a CI build of a RN project of version 0.59 if it is claimed to be supported?