Use collection expressions by martincostello · Pull Request #2715 · App-vNext/Polly

martincostello · 2025-08-22T13:14:02Z

Replace ToArray() and ToList() calls with collection expressions, where relevant.
Make a few lambdas static.
Add "Simmy" to the custom dictionary for the Visual Studio spellchecker.
Use primary constructor in GeneratorHelper.
Tidy up formatting of parameters.

Replace `ToArray()` and `ToList()` calls with collection expressions, where relevant.

Make a few delegates static.

Add "Simmy" to the custom dictionary for the Visual Studio spellchecker.

Use primary constructor in `GeneratorHelper`.

Tidy up formatting of parameters.

Copilot

Pull Request Overview

This PR modernizes the codebase by replacing ToArray() and ToList() calls with collection expressions where applicable, updates some lambdas to be static, adds "Simmy" to the Visual Studio spellchecker dictionary, converts GeneratorHelper to use a primary constructor, and improves parameter formatting.

Replaced LINQ method calls with collection expressions using the spread operator ([..])
Made lambdas static where they don't capture variables
Updated GeneratorHelper to use primary constructor syntax
Improved code formatting for method parameters

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/Polly.Specs/Wrap/IPolicyWrapExtensionSpecs.cs	Replace `ToList()` with collection expression
test/Polly.Specs/Helpers/PolicyTResultExtensionsAsync.cs	Format parameters and replace formatting
test/Polly.Specs/Helpers/PolicyTResultExtensions.cs	Improve parameter formatting
test/Polly.Specs/Helpers/ContextualPolicyTResultExtensions.cs	Format method parameters
test/Polly.Extensions.Tests/Telemetry/TelemetryListenerImplTests.cs	Replace `ToList()` with collection expressions
test/Polly.Core.Tests/Retry/RetryHelperTests.cs	Replace `ToArray()` with collection expression
test/Polly.Core.Tests/ResiliencePipelineTests.cs	Replace `ToArray()` with collection expression
src/Snippets/Docs/Retry.cs	Replace `ToImmutableArray()` with collection expression
src/Polly/Wrap/ISyncPolicyPolicyWrapExtensions.cs	Replace `ToArray()` with collection expression
src/Polly/Wrap/IAsyncPolicyPolicyWrapExtensions.cs	Replace `ToArray()` with collection expressions
src/Polly.Testing/ResiliencePipelineExtensions.cs	Make lambda `static`
src/Polly.Extensions/Telemetry/TelemetryUtil.cs	Replace `ToArray()` with collection expression
src/Polly.Extensions/Telemetry/TelemetryOptions.cs	Replace `ToList()` with collection expressions
src/Polly.Extensions/Telemetry/TelemetryListenerImpl.cs	Replace `ToList()` with collection expressions
src/Polly.Core/Utils/Pipeline/CompositeComponent.cs	Replace `ToList()` with array expression and make lambda `static`
src/Polly.Core/Simmy/Utils/GeneratorHelper.cs	Convert to primary constructor
src/Polly.Core/CircuitBreaker/CircuitBreakerManualControl.cs	Replace `ToArray()` with collection expressions
exclusion.dic	Add "simmy" to spellchecker dictionary
bench/Polly.Core.Benchmarks/Utils/Helper.StrategyPipeline.cs	Replace `ToArray()` with collection expression and make lambda `static`

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/Polly.Core/Utils/Pipeline/CompositeComponent.cs

codecov · 2025-08-22T13:19:05Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.12%. Comparing base (155c22e) to head (8e32954).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2715   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files         309      309           
  Lines        7118     7118           
  Branches     1006     1008    +2     
=======================================
  Hits         6842     6842           
  Misses        222      222           
  Partials       54       54

Flag	Coverage Δ
linux	`96.12% <100.00%> (ø)`
macos	`96.12% <100.00%> (ø)`
windows	`96.11% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Updated [Polly](https://github.com/App-vNext/Polly) from 8.5.2 to 8.6.5. <details> <summary>Release notes</summary> _Sourced from [Polly's releases](https://github.com/App-vNext/Polly/releases)._ ## 8.6.5 ## What's Changed * Extend NuGet package validation by @martincostello in App-vNext/Polly#2762 * Suppress S2094 warning by @martincostello in App-vNext/Polly#2765 * Refactor cake script by @martincostello in App-vNext/Polly#2769 * Pass timeout to `TimeoutRejectedException` by @martincostello in App-vNext/Polly#2827 **Full Changelog**: App-vNext/Polly@8.6.4...8.6.5 ## 8.6.4 ## What's Changed * Fix after-release and update CHANGELOG by @martincostello in App-vNext/Polly#2714 * Use collection expressions by @martincostello in App-vNext/Polly#2715 * Fix flaky mutants by @martincostello in App-vNext/Polly#2717 * fix documentation for ExecuteOutcomeAsync by @carvex21 in App-vNext/Polly#2710 * Bump MartinCostello.WaitForNuGetPackage by @martincostello in App-vNext/Polly#2721 * Bump sign tool by @martincostello in App-vNext/Polly#2722 * xunit v3 preparation by @martincostello in App-vNext/Polly#2723 * Add summary NuGet badges by @martincostello in App-vNext/Polly#2724 * Delete actionlint config by @martincostello in App-vNext/Polly#2730 * RateLimiting: add typed builder/guard tests and external limiter lifetime test by @mohammed-saalim in App-vNext/Polly#2711 * Update Dependabot auto-merge conditions by @martincostello in App-vNext/Polly#2736 * Bump NuGet packages by @martincostello in App-vNext/Polly#2738 * Bump dotnet-stryker to 4.8.1 by @martincostello in App-vNext/Polly#2739 * Simplify code by @martincostello in App-vNext/Polly#2740 * Update zizmor by @martincostello in App-vNext/Polly#2746 * Use NuGet Trusted Publishing by @martincostello in App-vNext/Polly#2751 * Respect override for PipelineExecuting and PipelineExecuted by @peter-csala in App-vNext/Polly#2752 ## New Contributors * @carvex21 made their first contribution in App-vNext/Polly#2710 * @mohammed-saalim made their first contribution in App-vNext/Polly#2711 **Full Changelog**: App-vNext/Polly@8.6.3...8.6.4 ## 8.6.3 ## What's Changed * Add release notes configuration by @martincostello in App-vNext/Polly#2678 * Simplify release workflow by @martincostello in App-vNext/Polly#2679 * Sign-off commits by @martincostello in App-vNext/Polly#2694 * Add GitHub sponsorship by @martincostello in App-vNext/Polly#2695 * Refactor project dependencies by @martincostello in App-vNext/Polly#2696 * Add zizmor by @martincostello in App-vNext/Polly#2698 * Update benchmarks by @martincostello in App-vNext/Polly#2712 * Reduce async overhead by @pentp in App-vNext/Polly#2664 * Update benchmarks by @martincostello in App-vNext/Polly#2713 ## New Contributors * @pentp made their first contribution in App-vNext/Polly#2664 **Full Changelog**: App-vNext/Polly@8.6.2...8.6.3 ## 8.6.2 ## What's Changed * Performance tweaks by @martincostello in App-vNext/Polly#2667 * Update dependencies by @martincostello in App-vNext/Polly#2668 * Update benchmark results by @martincostello in App-vNext/Polly#2669 ## New Contributors * @pentp made their first contribution in App-vNext/Polly#2667 **Full Changelog**: App-vNext/Polly@8.6.1...8.6.2 ## 8.6.1 ## What's Changed * Fix integer overflow in `BulkheadSemaphoreFactory` by @ahusseini in App-vNext/Polly#2638 * Generate SBOM by @martincostello in App-vNext/Polly#2640 * Attest artifacts by @martincostello in App-vNext/Polly#2647 ## New Contributors * @ahusseini made their first contribution in App-vNext/Polly#2638 **Full Changelog**: App-vNext/Polly@8.6.0...8.6.1 ## 8.6.0 ## What's Changed * Bump Stryker by @martincostello in App-vNext/Polly#2476 * Fix chaos example issue and enrich notes & diagram by @caigen in App-vNext/Polly#2482 * Add diagram for the main chaos page sample by @peter-csala in App-vNext/Polly#2484 * Fix broken CI by @martincostello in App-vNext/Polly#2497 * Remove .NET 6 SDK by @martincostello in App-vNext/Polly#2501 * Use Stryker Mutator Dashboard by @martincostello in App-vNext/Polly#2500 * Fix Polly.Testing mutations by @martincostello in App-vNext/Polly#2503 * Lint PowerShell scripts by @martincostello in App-vNext/Polly#2504 * Improve Polly coverage by @martincostello in App-vNext/Polly#2505 * Improve mutation score by @martincostello in App-vNext/Polly#2506 * Run CodeQL for GitHub Actions by @martincostello in App-vNext/Polly#2498 * Add missing mutations by @martincostello in App-vNext/Polly#2508 * Remove dotnet tool restore by @martincostello in App-vNext/Polly#2513 * Add missing coverage by @martincostello in App-vNext/Polly#2514 * Improve mutation test perf by @slang25 in App-vNext/Polly#2520 * Improve coverage by @martincostello in App-vNext/Polly#2526 * Remove System.Text.Json reference by @martincostello in App-vNext/Polly#2532 * Fix test summary reliability by @martincostello in App-vNext/Polly#2543 * Use AuthenticodeLint by @martincostello in App-vNext/Polly#2553 * Use actions/create-github-app-token by @martincostello in App-vNext/Polly#2572 * Fix Retry strategy ShouldHandle in example code by @marcrocny in App-vNext/Polly#2527 * Tweak docs formatting by @martincostello in App-vNext/Polly#2575 * Dispose registry which contains rate limiters by @peter-csala in App-vNext/Polly#2578 * Improve mutation tests performance by ensuring solution file isn't discovered by @slang25 in App-vNext/Polly#2589 * Update LICENSE metadata by @martincostello in App-vNext/Polly#2590 * Add HTTP client integration samples by @peter-csala in App-vNext/Polly#2587 * Dedupe links by @martincostello in App-vNext/Polly#2592 * Add test analytics by @martincostello in App-vNext/Polly#2593 * Add note about context/state mix-ups by @martincostello in App-vNext/Polly#2598 * Emit annotation for packages by @martincostello in App-vNext/Polly#2601 * Add `AttemptNumber` to `HedgingPredicateArguments` by @peter-csala in App-vNext/Polly#2603 * .NET 10 preparation by @martincostello in App-vNext/Polly#2620 * Migrate to slnx by @martincostello in App-vNext/Polly#2623 * Fix `OnRetryArguments` comments by @lchaoer in App-vNext/Polly#2627 * Fix package signing by @martincostello in App-vNext/Polly#2631 ## New Contributors * @caigen made their first contribution in App-vNext/Polly#2482 * @slang25 made their first contribution in App-vNext/Polly#2520 * @marcrocny made their first contribution in App-vNext/Polly#2527 * @lchaoer made their first contribution in App-vNext/Polly#2627 **Full Changelog**: App-vNext/Polly@8.5.2...8.6.0 Commits viewable in [compare view](App-vNext/Polly@8.5.2...8.6.5). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Polly&package-manager=nuget&previous-version=8.5.2&new-version=8.6.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

martincostello added 5 commits August 22, 2025 14:10

Use collection expressions

32676f0

Replace `ToArray()` and `ToList()` calls with collection expressions, where relevant.

Make delegates static

600ab94

Make a few delegates static.

Add Simmy to dictionary

7ac5dc1

Add "Simmy" to the custom dictionary for the Visual Studio spellchecker.

Use primary constructor

32af9a1

Use primary constructor in `GeneratorHelper`.

Tidy-up formatting

8e32954

Tidy up formatting of parameters.

Copilot AI review requested due to automatic review settings August 22, 2025 13:14

Copilot AI reviewed Aug 22, 2025

View reviewed changes

src/Polly.Core/Utils/Pipeline/CompositeComponent.cs Show resolved Hide resolved

martincostello enabled auto-merge (rebase) August 22, 2025 13:14

martincostello merged commit f25f2c5 into main Aug 22, 2025
32 of 34 checks passed

martincostello deleted the collection-expressions branch August 22, 2025 13:42

This was referenced Mar 2, 2026

Bump Polly from 8.4.2 to 8.6.5 mobby57/memoLib#143

Closed

Bump Polly from 8.5.2 to 8.6.5 PhilipWoulfe/F1Competition#43

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use collection expressions#2715

Use collection expressions#2715
martincostello merged 5 commits intomainfrom
collection-expressions

martincostello commented Aug 22, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

codecov bot commented Aug 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

martincostello commented Aug 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

codecov bot commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Aug 22, 2025 •

edited

Loading