Closed
Conversation
There was a problem hiding this comment.
Copilot reviewed 143 out of 158 changed files in this pull request and generated no comments.
Files not reviewed (15)
- Directory.Packages.props: Language not supported
- eng/Test.targets: Language not supported
- src/Snippets/Snippets.csproj: Language not supported
- test/Polly.Core.Tests/CircuitBreaker/Controller/CircuitStateControllerTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/BrokenCircuitExceptionTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/IsolatedCircuitExceptionTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/Fallback/FallbackHandlerTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerResiliencePipelineBuilderTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerOptionsTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerResilienceStrategyTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/Fallback/FallbackResiliencePipelineBuilderExtensionsTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerStateProviderTests.cs: Evaluated as low risk
- src/Snippets/Docs/Testing.cs: Evaluated as low risk
- build.cake: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerPredicateArgumentsTests.cs: Evaluated as low risk
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2440 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 309 309
Lines 7128 7128
Branches 1005 1005
=======================================
Hits 6854 6854
Misses 221 221
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
0d89f44 to
43001fd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Merged
43001fd to
d4bf38c
Compare
martincostello
added a commit
that referenced
this pull request
Aug 23, 2025
Cherry-pick changes from #2440 to prepare to switch to xunit v3.
Merged
martincostello
added a commit
that referenced
this pull request
Aug 23, 2025
Cherry-pick changes from #2440 to prepare to switch to xunit v3.
Update to xunit v3. Resolves #2439.
38f4de9 to
e28f271
Compare
Youssef1313
reviewed
Dec 25, 2025
Directory.Packages.props
Outdated
| <PackageVersion Include="System.ValueTuple" Version="4.5.0" /> | ||
| <PackageVersion Include="xunit" Version="2.9.3" /> | ||
| <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.4" /> | ||
| <PackageVersion Include="xunit.v3" Version="3.0.1" /> |
There was a problem hiding this comment.
Consider using xunit.v3.mtp-v2 instead. Latest version is 3.2.1.
Youssef1313
reviewed
Dec 25, 2025
Directory.Packages.props
Outdated
| <PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.5.4" /> | ||
| <PackageVersion Include="System.ValueTuple" Version="4.5.0" /> | ||
| <PackageVersion Include="xunit" Version="2.9.3" /> | ||
| <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.4" /> |
There was a problem hiding this comment.
This shouldn't be needed if you intend to also run with MTP.
martincostello
commented
Jan 2, 2026
Use `xunit.v3.mtp-v2` instead of `xunit.v3`.
martincostello
commented
Jan 2, 2026
Remove now-redundant reference to xunit.runner.visualstudio.
martincostello
commented
Jan 2, 2026
Remove redundant package reference.
Switch to using FsCheck.Xunit.v3.
GitHubActionsTestLogger isn't strong-named which means MTP can't compile due to the strong-name requirement, so disable it.
Member
Author
|
Styker tests are still broken both without MTP (stryker-mutator/stryker-net#3117) and with MTP (stryker-mutator/stryker-net#3094). Unit tests only work with MTP disabled, otherwise the fact GitHubActionsTestLogger isn't strong-named becomes a problem and causes test compilation to fail. |
Member
Author
|
I'm going to close this out as it's otherwise about to reach its first birthday. We can revisit in the future if/when stryker supports MTP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2439.