Merged
Conversation
martincostello
added a commit
to martincostello/Polly
that referenced
this pull request
Mar 1, 2024
- Fix CA1849 warning from updating snippets to .NET 8. - Fix IDE0034 warning identified by the .NET 9 SDK in App-vNext#2003.
martincostello
added a commit
that referenced
this pull request
Mar 1, 2024
- Update various sample projects from `net7.0` to `net8.0`. - Fix CA1849 warning from updating snippets to .NET 8. - Fix IDE0034 warning identified by the .NET 9 SDK in #2003.
a29ccc2 to
7ca1b0c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2003 +/- ##
==========================================
- Coverage 85.40% 85.39% -0.01%
==========================================
Files 313 312 -1
Lines 7467 7464 -3
Branches 1125 1121 -4
==========================================
- Hits 6377 6374 -3
Misses 745 745
Partials 345 345
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
336f454 to
7952a24
Compare
7952a24 to
ee658b4
Compare
6200a8c to
a26bc60
Compare
martincostello
commented
Apr 12, 2024
martincostello
added a commit
to martincostello/Polly
that referenced
this pull request
Apr 12, 2024
Fix IDE0057 warnings identified in App-vNext#2003.
This was referenced Apr 12, 2024
martincostello
added a commit
that referenced
this pull request
Apr 12, 2024
Fix IDE0057 warnings identified in #2003.
e823391 to
36ecb34
Compare
36ecb34 to
82a3c08
Compare
bee5858 to
eeac2c2
Compare
f18d2e9 to
ff96865
Compare
ff96865 to
4bc4037
Compare
9a1e910 to
be46d64
Compare
255c73a to
98ba53f
Compare
3436c6b to
51e0bf2
Compare
e548cc6 to
7b6aa5a
Compare
28ff68a to
9aa38cf
Compare
This was referenced Oct 23, 2025
This was referenced Nov 3, 2025
This was referenced Nov 24, 2025
Open
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Jan 1, 2026
This was referenced Jan 19, 2026
This was referenced Jan 29, 2026
This was referenced Feb 24, 2026
This was referenced Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long-lived PR for testing .NET 9 until the stable release in November 2024.
net9.0is explicitly not being added as a new TFM for the packages we ship to NuGet.org.Changes include:
[DebuggerDisableUserUnhandledExceptions]to avoid newer versions of the Visual Studio debugger for breaking for exceptions on async code paths we are intentionally handling.net8.0andnet9.0in tests, samples and benchmarks.net6.0target from tests, samples and benchmarks as it will both be out-of-support by November 2024.