Empty antler-run with eos-vm and eosiolib linked#94
Merged
Conversation
spoonincode
previously requested changes
Jan 26, 2023
This reverts commit f926d59.
larryk85
suggested changes
Feb 2, 2023
Contributor
larryk85
left a comment
There was a problem hiding this comment.
Small changes, other than that looking good.
libraries/native/macho_crt.s
Outdated
| mov %rdx, %rsp | ||
| mov 56(%rdi), %rdx | ||
| jmp *%rdx | ||
| syscall No newline at end of file |
Contributor
There was a problem hiding this comment.
We can remove this macho_crt.s for the time being as we don't support mac os directly for the foreseeable future.
Contributor
Author
There was a problem hiding this comment.
I wanted to do this in a separate commit, as there are few more places with mac os specifics.
larryk85
approved these changes
Feb 13, 2023
Contributor
larryk85
left a comment
There was a problem hiding this comment.
Does this break anything currently in use? If it does then let's make a branch called next_release and merge to that.
Contributor
Author
|
@larryk85 tests are fine and binary workflow supposed to be unchanged, I made two different implementations - |
nathanielhourt
pushed a commit
to dapp-protocols/leap-cdt
that referenced
this pull request
Feb 26, 2023
dimas1185
added a commit
that referenced
this pull request
Jun 8, 2023
dimas1185
added a commit
that referenced
this pull request
Sep 21, 2023
This reverts commit 226f497.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#79
Challenges:
eosiolibhaven't been built withgcc. it was only built withcdt-cppbefore. However when we includedeosiolibintoantler-runwe got chicken and egg problem: all tools are built with default compiler (gcc in case of Ubuntu) and theneosiolibbuilt with those tools. Solution was to slightly changeeosiolibto be built with gcc. So now we have two versions ofeosioliblib for different purposes.libraries/libc++. The reason to use standard library is because of we addeos-vmas well and there were a lot to fix to get it along with customlibc++.Libc++lacksfstreamand other stuff that is needed byeos-vm.antler-run. Issue with it was that we can't have our own_startwith standard library. So this code was split to avoid this function included forantler-runbinary.nativelibrary now also has two native builds with different toolchains (gcc and cdt-cpp).Note: there is a decision to remove Mac support. This PR maintains Mac support in order to makes changes distinct. I'm planning to make another PR to remove Mac support.
Change Description
API Changes
Documentation Additions