[4.0] remove is_callable_v<> workaround, fixing build on latest clang#233
Merged
spoonincode merged 1 commit intorelease/4.0from Sep 25, 2023
Merged
Conversation
is_callable_v<> workaround, fixing build on latest clangis_callable_v<> workaround, fixing build on latest clang
heifner
approved these changes
Sep 25, 2023
linh2931
approved these changes
Sep 25, 2023
spoonincode
added a commit
that referenced
this pull request
Sep 26, 2023
[4.0 -> main] merge up #233: remove `is_callable_v<>` workaround
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
is_callable_v<>()workaround causes build breakage on newer clang (such as latest two versions of Xcode). Fix is identical to AntelopeIO/eos-vm#4Sending this to 4.0.x is a little debatable, but 4.0.x may live for quite some time so it's nice to get macOS build fully operational again.