fix(ui): restore changelog dialog visibility after fresh install#1030
Merged
Conversation
Removed premature setUpdated() call from the isFreshInstall branch that permanently cleared the isUpdated flag before the changelog code could execute. Added a hasCheckedInstallation session guard to prevent double-invocation via bottom sheet lifecycle triggering a second onResume cycle, which would stack the changelog on top of the intro guide.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a regression from #1029 where the changelog dialog was permanently hidden after a fresh install.
Root Cause
In
checkNewInstallation(), thesetUpdated()call inside theisFreshInstallbranch prematurely cleared theisUpdatedflag, thenreturnprevented reaching the actual changelog code below. This made the changelog never show for any launch.Additionally, the bottom sheet lifecycle triggered a second
onResume()cycle, causingcheckNewInstallation()to run twice. AfterisFreshInstallwas cleared by the first call, the second call would hitisUpdated=trueand stack the changelog dialog on top of the intro guide.Fix
setUpdated()from theisFreshInstallbranch — thereturnalone prevents stacking; letisUpdatedsurvive for the next launch.hasCheckedInstallationsession guard — prevents the method from executing more than once per activity instance, eliminating the double-invocation caused by the bottom sheet lifecycle.Behavior