fix(ui): Improve media card interactions and fix startup dialog stacking#1029
Merged
Conversation
… state - Fix stuck pull-to-refresh by making animation callbacks reliable - Fix comment pagination using correct loading state - Fix getTopFavouriteYears() returning wrong cached list - Add regression test for presenter bug
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Performance | 2 medium |
🟢 Metrics 0 complexity · -2 duplication
Metric Results Complexity 0 Duplication -2
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
- Attach click listeners to all media card child views to fix browse card body taps - Route card clicks back to itemView container for consistent handling - Reorder fresh install and changelog dialog checks to prevent stacking - Optimize changelog asset read using bufferedReader instead of byte-by-byte reading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Media Card Interactions: Attach click listeners to all media card child views to fix browse card body taps. Routes card clicks back to itemView container for consistent handling.
Startup Dialog Stacking: Reorder fresh install and changelog dialog checks in MainActivity to prevent both dialogs from showing simultaneously, eliminating ANR risk.
Asset Loading: Optimize changelog asset read using bufferedReader instead of byte-by-byte reading for improved performance.
Files Modified