Replace non-atomic load with an atomic one#72
Merged
Amanieu merged 6 commits intoAmanieu:masterfrom Feb 20, 2024
james7132:fix-iter-ub
Merged
Replace non-atomic load with an atomic one#72Amanieu merged 6 commits intoAmanieu:masterfrom james7132:fix-iter-ub
Amanieu merged 6 commits intoAmanieu:masterfrom
james7132:fix-iter-ub
Conversation
notgull
suggested changes
Feb 17, 2024
notgull
left a comment
There was a problem hiding this comment.
You should add a test that makes sure the issue isn't still active.
Contributor
Author
Tried earlier, and it's surprisingly hard to get miri to fire with a minimal repro. I'll take another stab at this soon. |
Contributor
Author
|
Added a test, made sure it fails with miri on |
Amanieu
reviewed
Feb 20, 2024
Contributor
Author
|
As a final sanity check, I reran the benchmarks in the repo, and it seems like this shouldn't negatively affect performance, at least not on x86 platforms: |
Owner
|
We are waiting on #69 to fix CI. This will bump the Rust version used in CI, so you will be able to use black_box for benchmarks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70 by replacing the non-atomic load in
get_innerwith an atomic one.