Add Cargo.lock to the repo to fix flaky CI#69
Conversation
|
It's generally a bad pattern to commit CI is still failing because of regex-automata, which requires 1.65. At this point I would just bump the CI to 1.72 (which should be enough for most of our dev-dependencies) while keeping the MSRV in Cargo.toml at 1.60. |
done
Not any more: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
But either way, I can also remove it again from the PR if you prefer that. |
|
CI is still failing, it seems clap requires 1.74. Just bump CI up to that (and continue bumping as needed). |
Previously, CI was breaking "randomly" every time a dependency moved its MSRV beyond whatever is used to run in CI. To fix that, just commit the lockfile to git so that CI runs with a fixed set of dependencies. Also adds my own `rust-cache` for good measure :-)
Done. Lets hope this is enough ;-) |
|
Great! Can you rebase your other PRs so they pass CI. |
|
Nevermind, I went ahead and rebased them myself. |
Previously, CI was breaking "randomly" every time a dependency moved its MSRV beyond whatever is used to run in CI. To fix that, just commit the lockfile to git so that CI runs with a fixed set of dependencies. Also adds my own
rust-cachefor good measure :-)Lets hope that raising this to
1.63is actually far enough. Personally, I would just take #64 and bump MSRV as far as is comfortable. It is a bit weird that a much higher Rust version is used in CI than specified in MSRV, so there is zero guarantee that the MSRV is actually correct 🤷🏻♂️