Improve the FIB iterator available for the dynamic configuration block#493
Merged
AltraMayor merged 5 commits intomasterfrom Jun 8, 2021
Merged
Improve the FIB iterator available for the dynamic configuration block#493AltraMayor merged 5 commits intomasterfrom
AltraMayor merged 5 commits intomasterfrom
Conversation
A FIB can be rather large (e.g. ~1 million entries), so the cost to iterate it should be minimized.
A FIB can be rather large and a Lua code may want only a few entries, so stop the iterator as soon as the Lua code is satisfied.
Moving control out of dylib.print_fib_dump_entry() makes it easier for someone to write a personalized version of dylib.print_fib_dump_entry().
Owner
Author
|
Tested in production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pull request #489 brought up, the FIB iterator is the most demanding iterator available through the dynamic configuration block. This pull request improves the code of this iterator to further save time.
This pull request also adds two new
gkctlscripts to only list grantor FIB entries. Not only are these new scripts useful in production, but they also serve as examples of how to filter any subset of FIB entries.