Merged
Conversation
The original dylib.print_fib_dump_entry() would concat strings multiple times per FIB entry while accumulating the whole output in a single string. This algorithm takes a minute to dump a modest-sized routing table. This patch rewrites dylib.print_fib_dump_entry() to use string buffers (i.e. table.concat()). Dumping a large routing table now takes less than a second.
Owner
Author
|
Tested in production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scripts shipped with
gkctlwere very slow because they would copy the content of the accumulator string multiple times per record of the table being dumped. The new code only concatenates the strings at the very end by calling the efficienttable.concat()of Lua. The original scripts would take a minute to dump a modest-sized routing table, while the new code accomplishes the same task in less than a second.