Merged
Conversation
- Introduced chunk size control for object storage backups. - Tested successfully with various chunk sizes.
- Introduced chunk size control for object storage backups.
- Tested successfully with various chunk sizes.
- When the file size was divided based on chunk_size, it was modified not to exceed 10000.
- Introduced chunk size control for object storage backups.
- Tested successfully with various chunk sizes.
- When the file size was divided based on chunk_size, it was modified not to exceed 10000.
- Update the variables you refer to when calculating partSize.
Collaborator
|
you don't need open new pull request for every commit |
Collaborator
|
use following commdands then commit changed |
Signed-off-by: Slach <bloodjazman@gmail.com>
Collaborator
|
i changed,let's wait CI/CD |
Pull Request Test Coverage Report for Build 17823211847Details
💛 - Coveralls |
Slach
added a commit
that referenced
this pull request
Sep 18, 2025
Signed-off-by: Slach <bloodjazman@gmail.com>
Slach
added a commit
that referenced
this pull request
Sep 18, 2025
Signed-off-by: Slach <bloodjazman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
We are backing up ClickHouse databases to MINIo object storage in a private cloud environment.
Problem
When using the existing max_parts_count configuration, we encountered excessive load during backup operations. This caused resource contention issues and slowed down uploads, especially with larger backups.
Solution
I added a new option to control chunk size during object storage uploads. By adjusting the chunk size, we can optimize resource usage and avoid spikes in network or disk load. This feature has been tested successfully in our environment.
Update
When the file size was divided based on chunk_size, it was modified not to exceed 10000.
Update the variables you refer to when calculating partSize.
Request
I hope this chunk size control feature can be officially included in the project to provide better flexibility for MINIo and similar scenarios.
Please let me know if any changes are needed or if further testing is required. Thank you!