Skip to content

fix: patch mistaken overrides#5569

Merged
mergify[bot] merged 2 commits into
masterfrom
markm-patch-bad-overrides
Jun 10, 2022
Merged

fix: patch mistaken overrides#5569
mergify[bot] merged 2 commits into
masterfrom
markm-patch-bad-overrides

Conversation

@erights

@erights erights commented Jun 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Patch mistaken overrides.

These were the overrides that prevent us from changing

agoric-sdk/packages/agoric-cli/test/test-main.js

Line 4 in 09b239d

import '@endo/init';

to

import '@endo/init/debug.js';

at
#5567
since debug.js also sets overrideTaming to 'min' as it should, in order to catch such problems.

@erights erights self-assigned this Jun 10, 2022
@erights erights requested review from kriskowal and turadg June 10, 2022 19:45
turadg
turadg approved these changes Jun 10, 2022
View reviewed changes

@turadg turadg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does enumerable: true cause the problem?

Approving since I assume you have a good answer : )

@erights

erights commented Jun 10, 2022

Copy link
Copy Markdown
Member Author

Why does enumerable: true cause the problem?

Approving since I assume you have a good answer : )

Clarified by adding

+            // enumerable: true would accurately preserve the behavior of the
+            // original assignment, but I'm guessing that was not intentional.
+            // For an actual error subclass, this property would not
+            // be enumerable.

to all the relevant enumerable: false cases.

@erights erights force-pushed the markm-patch-bad-overrides branch from fc2dc50 to b1d7651 Compare June 10, 2022 21:31
@erights erights added the automerge:squash Automatically squash merge label Jun 10, 2022
@mergify mergify Bot merged commit 93f0a77 into master Jun 10, 2022
@mergify mergify Bot deleted the markm-patch-bad-overrides branch June 10, 2022 22:10
@erights erights mentioned this pull request Jun 10, 2022
Merged
Chris-Hibbert pushed a commit that referenced this pull request Jun 13, 2022
@erights @Chris-Hibbert
fix: patch mistaken overrides (#5569)
9db08ea 
* fix: patch mistaken overrides

* fix: clarifying for review comment
@erights erights mentioned this pull request Jul 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@turadg turadg turadg approved these changes

@kriskowal kriskowal Awaiting requested review from kriskowal

Assignees

@erights erights

Labels

automerge:squash Automatically squash merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erights @turadg