Merged
Conversation
915de5e to
449b49b
Compare
turadg
reviewed
May 4, 2022
6cc2d43 to
b97d552
Compare
Closed
b97d552 to
6161670
Compare
FUDCo
added a commit
that referenced
this pull request
May 11, 2022
In support of #5283. @erights and @Chris-Hibbert encountered this in the course of testing their durabilization of ERTP. Note that this bug only implicates tests and not the actual underlying virtual objects implementation.
FUDCo
added a commit
that referenced
this pull request
May 11, 2022
In support of #5283. @erights and @Chris-Hibbert encountered this in the course of testing their durabilization of ERTP. Note that this bug only implicates tests and not the actual underlying virtual objects implementation.
b0b055a to
ab82555
Compare
1ef34af to
0077690
Compare
fb9fe3d to
630434e
Compare
630434e to
4df338c
Compare
erights
added a commit
that referenced
this pull request
May 21, 2022
4df338c to
5b87a66
Compare
erights
added a commit
that referenced
this pull request
May 21, 2022
8fe0531 to
96bb0bc
Compare
Member
Author
|
See also #5674 I will probably merge that one into this before proceeding with this. I'll PTAL at that time. |
767e937 to
4ba2c9e
Compare
4ba2c9e to
3552107
Compare
4ba2c9e to
3c6f10c
Compare
239a828 to
d037ae4
Compare
d037ae4 to
f6003cc
Compare
turadg
reviewed
Jun 29, 2022
packages/ERTP/test/swingsetTests/ertpService/vat-ertp-service.js
Outdated
Show resolved
Hide resolved
d2ad04b to
da2b250
Compare
erights
commented
Jul 5, 2022
Member
Author
|
@FUDCo please review at least the SwingSet portion of this PR. Thanks. |
FUDCo
reviewed
Jul 7, 2022
Collaborator
There was a problem hiding this comment.
W.r.t the changes to SwingSet: Much of it is tweaks dealing with error message censorship, which is always a pain, and my take on these is pretty much "yeah, whatever". I'm not convinced that the error censorship stuff is adding more value than it subtracts but it's not time to litigate that now.
I do have some serious misgivings about isDurableObject (see comment).
6162bdc to
e5c1e75
Compare
Member
Author
turadg
approved these changes
Jul 8, 2022
Member
turadg
left a comment
There was a problem hiding this comment.
Approved with some non-blocking suggestions.
turadg
approved these changes
Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ERTP Durable