test: try agoric-sdk with "no-passable-symbols" endo#10084
Draft
test: try agoric-sdk with "no-passable-symbols" endo#10084
Conversation
Deploying agoric-sdk with
|
| Latest commit: |
1d9f98d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09d2e5f3.agoric-sdk.pages.dev |
| Branch Preview URL: | https://markm-test-w-some-endo-3.agoric-sdk.pages.dev |
323d327 to
1d9f98d
Compare
This was referenced Dec 22, 2024
erights
added a commit
to endojs/endo
that referenced
this pull request
Jan 1, 2025
Closes: #XXXX Refs: - ocapn/ocapn#125 - https://github.com/ocapn/ocapn/blob/28af626441da888c4a520309222e18266dd2f1f2/draft-specifications/Model.md - #2452 - Agoric/agoric-sdk#10084 - https://github.com/tc39/proposal-immutable-arraybuffer - #2414 ## Description Revise Smallcaps cheatsheet to track OCapn as of ocapn/ocapn#125 ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations the point. The cheatsheet was becoming too stale. ### Testing Considerations none ### Compatibility Considerations none ### Upgrade Considerations none
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for passable symbols from the Agoric SDK to test compatibility with the "no-passable-symbols" version of Endo. The changes systematically eliminate symbol handling across various components.
- Removes symbol type checks and handling from proxy operations and marshaling utilities
- Updates telemetry and debugging code to no longer process symbol-based method names
- Eliminates symbol-related serialization cases from slogulator and kdebug modules
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/vats/src/core/utils.js | Removes symbol type check from proxy getter |
| packages/telemetry/src/slog-to-otel.js | Updates method type annotation and removes symbol handling in message parsing |
| packages/swingset-runner/src/slogulator.js | Removes symbol serialization cases from value and method legibilization |
| packages/swingset-liveslots/src/liveslots.js | Updates DeviceHandler to only accept string properties |
| packages/swingset-liveslots/src/kdebug.js | Removes symbol handling from value and method legibilization |
| packages/swingset-liveslots/src/facetiousness.js | Removes symbol property check from facet assessment |
| packages/smart-wallet/src/offerWatcher.js | Removes symbol case from result type handling |
| packages/internal/src/callback.js | Removes isPassableSymbol import and symbol validation from callback methods |
| packages/SwingSet/test/upgrade/upgrade.test.js | Adds gratuitous comment for PR creation |
| packages/SwingSet/src/lib/kdebug.js | Removes symbol handling from value and method legibilization |
| packages/SwingSet/src/kernel/deviceSlots.js | Updates proxy to only accept string properties |
| packages/SwingSet/src/controller/controller.js | Removes symbol type checks from queue methods |
Comment on lines
142
to
146
| get: (t, propName) => { | ||
| if (typeof propName !== 'symbol') { | ||
| propName in t || | ||
| Fail`${q(propName)} not permitted, only ${q(keys(template))}`; | ||
| } | ||
| propName in t || | ||
| Fail`${q(propName)} not permitted, only ${q(keys(template))}`; | ||
| return t[propName]; | ||
| }, |
There was a problem hiding this comment.
Removing the symbol type check without adding proper type validation could allow non-string property access to bypass the permission check. The condition propName in t will still execute for symbols, but the error message assumes string properties.
| }; | ||
| }; | ||
|
|
||
| // Gratuitous change so I can create an otherwise identical PR |
There was a problem hiding this comment.
This gratuitous comment should be removed as it adds no value to the codebase and appears to be temporary scaffolding for PR creation.
Suggested change
| // Gratuitous change so I can create an otherwise identical PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#endo-branch: markm-no-passable-symbols
closes: #XXXX
refs: endojs/endo#2452
Description
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations