Change default accent colors for dark themes#969
Merged
Adamantcheese merged 1 commit intoJul 2, 2020
Merged
Conversation
Adamantcheese
added a commit
that referenced
this pull request
Jul 2, 2020
…t is needed to "revert" the change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dark themes had the accent set to dark/black by default which was causing a lot of visibility issues. It seems many people haven't figured out the accent color is changeable. This PR changes the default accent colors of dark themes to be brighter and more easily distinguishable from the background. I tried to pick each accent color so that it fits the theme it's set for.
Also includes a tiny change to the select layout, the 'SELECT ALL' button in the filter menu (under filter type and board) now matches the style of the button elsewhere in the app.
EDIT: if this gets merged would you consider reverting ba5a721 ? Since the loading bar following the accent color (which is a nice idea I think) wasn't really the issue per se but rather the accent color being set to dark/black on a dark theme.