(#413) Add 420chan support#518
Conversation
idk how it compiled just minutes ago
taken from dvach
|
So, i'm pretty much where i was before except by commenting out defaultRules in TaimabaCommentParser strikethrough is not considered a spoiler. The necessary changes made to TaimabaApi were ripped off from Overchan. That's kinda why i didn't include these in the first place, because now the problem is that whatever i've tried i couldn't manage to properly implement inlinequoting (always weird results when it worked, like ALL text or only the last inline quote colored) and quoting (was linkified but clicking on it had no result). I'll be focusing on trying to get posting going even though i'll probably need a lot of time. |
still throws an error, don't know how to proceed further
*use defaultrules (for quotes to work) *rename tagrule "s" to "strike" to prevent colliding with defaultrule for spoilers *use correct quote patterns *remove comments/cleanup
throws an onPostComplete error, but the post arrives
|
Posting does work, but throws an onPostComplete error, unsure why. Probably because replyResponse.posted is not true. These are the two issues i see as of now. |
|
In your Actions class, there's a handlePost method that takes care of setting replyResponse.posted. You may need to adjust the regex inside that method for it to properly set that, so you can do what Wired7 did, which is copy the method and change the regex. The site itself seems to redirect to the board homepage, which is stupid, but will probably make your life more difficult for determining what thread number and post number the reply response is associated with, since those are being parsed from the request URL. |
|
Yep figured that much out, but i couldn't really figure out the correct pattern. However after i read that the site redirects you to the board overview anyways i figured i try a hacky method of just storing the threadNo, postNo & password from reply values of the setupPost method and use them directly. I'll commit the way it is now for review, but i'll keep tinkering around and revert/update once i get the proposed way working. There also are a lot of minor issues which need to be taken care of/worked around (reply/image count, when posting with an image the file size is a negative value and triggers the warnign "file size too big" (but posts correctly), sage doesn't work) I may find some more, but these are on the todo list for now. EDIT: correct errorPattern is now used and errors show up correctly. |
|
moved comment to first comment |
limitations: *the webview isn't helpful other than confirming the report has been sent *the reason will always be "RULE_VIOLATION", never "ILLEGAL_CONTENT" *the (supposed to be helpful and descriptive text) will always be "Kuroba generated report")
these icons are from https://www.pngrepo.com/vectors/files-3/2&type=multicolor Licensed under Creative Commons 4.0
based on the initial implementation in Kuroba see Adamantcheese#518
savedReply (You)sreply/image count