Skip to content

feat: progress on audible-as-active#262

Merged
ErikBjare merged 3 commits intomasterfrom
dev/new-audible
Feb 28, 2021
Merged

feat: progress on audible-as-active#262
ErikBjare merged 3 commits intomasterfrom
dev/new-audible

Conversation

@ErikBjare
Copy link
Copy Markdown
Member

@ErikBjare ErikBjare commented Feb 25, 2021

I just banged this out without testing it at all, not sure if it'll work.

Edit: Huh, it wasn't too stupid after all. Seems to work...

Also re-adds the 'filter AFK' option.

Replaces #85

Partially fixes ActivityWatch/activitywatch#261

Things to fix

  • Prettier checkboxes at the bottom of the activity page
  • More extensive testing?

@ErikBjare ErikBjare marked this pull request as ready for review February 25, 2021 21:48
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2021

Codecov Report

Merging #262 (1c733ce) into master (86b8eab) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   13.89%   13.84%   -0.06%     
==========================================
  Files          22       22              
  Lines        1036     1040       +4     
  Branches      101      105       +4     
==========================================
  Hits          144      144              
- Misses        847      851       +4     
  Partials       45       45              
Impacted Files Coverage Δ
src/queries.ts 15.06% <0.00%> (-0.88%) ⬇️
src/store/modules/activity.ts 6.10% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b8eab...1c733ce. Read the comment docs.

Copy link
Copy Markdown
Member

@johan-bjareholt johan-bjareholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised that it was this clean to implement, can't really see any flaws. Well done!

@ErikBjare
Copy link
Copy Markdown
Member Author

Did a bit more testing, seems to work fine. Merging when CI passes.

@johan-bjareholt
Copy link
Copy Markdown
Member

@ErikBjare Not working with aw-server-rust, there was one query method missing (forgotten which one, noticed a few days ago).

I think it should be pretty easy to fix though.

@ErikBjare
Copy link
Copy Markdown
Member Author

I assume it's period_union?

@dtgay
Copy link
Copy Markdown

dtgay commented Dec 1, 2022

Seems like this feature doesn't work on Brave due to ActivityWatch/activitywatch#461. Can anyone else confirm?

The tab activity is being marked as audible, but I think since the browser watcher isn't working it fails to qualify for the AFK exception. I think the relevant code might be around this area: https://github.com/ActivityWatch/aw-webui/pull/262/files#diff-97651250ee5b39a1d46e9d92b574a8d7ee98ebb31335fb8bc3ee072641097f9aR73-R78

Looks like #375 might be a workaround but doesn't appear to be available in latest (0.12.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More accurately record time spent consuming video media

3 participants