feat: added "count-as-active" setting to always count some apps/titles as active#375
Merged
ErikBjare merged 7 commits intoActivityWatch:masterfrom Oct 17, 2022
Merged
Conversation
- Never treat some app with process names or titles matching a Regex pattern as AFK - Added a browser setting for the same - Future todo can be to implement a server query function of the form filter_keyvalues_regex( <events>, "*", <Regex> ) which will match all attr's of event like categorize() (future url support etc.)
ErikBjare
reviewed
Oct 12, 2022
Member
ErikBjare
left a comment
There was a problem hiding this comment.
Very nice! Thank you so much for this!
Just some comments, eager to merge soon :)
ErikBjare
reviewed
Oct 12, 2022
Codecov ReportBase: 25.58% // Head: 25.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
==========================================
+ Coverage 25.58% 25.69% +0.10%
==========================================
Files 26 26
Lines 1442 1448 +6
Branches 226 229 +3
==========================================
+ Hits 369 372 +3
- Misses 1020 1046 +26
+ Partials 53 30 -23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
- remove ActivityData wrapping - Added some consumer friendly explanation in Settings - Added validation to skip some events
Member
|
Added some validation and did some testing, works great now! Thank you for your contribution @ShootingKing-AM ❤️ |
ErikBjare
reviewed
Oct 17, 2022
This was referenced Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example data,
Pre-Filter setting,
Setting,
Post-Filter setting,
Relevant issues: ActivityWatch/activitywatch#261