fix: add a brave-specific check #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 39bb78f in 47 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/client.js:26
- Draft comment:
It's crucial to ensure that new features like the Brave browser check are thoroughly tested across various environments, not just manually on a single machine. Consider implementing automated tests to verify the behavior across different scenarios. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_bqQ5OuxbUTQq9lMM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 5 hours left in your free trial, upgrade for $20/seat/month or contact us.
Member
|
Nice, thanks! |
powellnorma
pushed a commit
to powellnorma/aw-watcher-web
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Brave specific API to check if the browser is Brave.
Manually tested, works on my machine :)
Summary:
This PR optimizes browser detection by adding a Brave-specific check in the
getBrowserNamefunction ofsrc/client.js, improving performance by avoiding unnecessary operations.Key points:
navigator.brave?.isBrave()ingetBrowserNamefunction insrc/client.js.Generated with ❤️ by ellipsis.dev