Skip to content

Minor build and CI fixes#1599

Merged
hodoulp merged 7 commits intoAcademySoftwareFoundation:mainfrom
remia:build-fix
Mar 24, 2022
Merged

Minor build and CI fixes#1599
hodoulp merged 7 commits intoAcademySoftwareFoundation:mainfrom
remia:build-fix

Conversation

@remia
Copy link
Copy Markdown
Collaborator

@remia remia commented Feb 11, 2022

Fix the analysis workflow

The install location for built dependencies in the analysis workflow is now explicit in Linux and macOS (Windows already use a custom location). This is because OpenImageIO now started to override the install location to point in the build tree when none is specified, instead of using standard Unix paths.

Currently failing on OpenEXR Windows build, see related issue AcademySoftwareFoundation/openexr#1236

Fix issue in static builds on Windows #1581

Fix #1593

Improve documentation for OFX build #1607

Copy link
Copy Markdown
Member

@hodoulp hodoulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. I made a comment to better explain the new unit test.

@hodoulp
Copy link
Copy Markdown
Member

hodoulp commented Mar 11, 2022

@remia What is the status of this pull request?

@remia
Copy link
Copy Markdown
Collaborator Author

remia commented Mar 11, 2022

@remia What is the status of this pull request?

This PR is ready to merge now from my point of view @hodoulp.

Copy link
Copy Markdown
Collaborator

@doug-walker doug-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Remi!

There seems to be an analysis build failure on Windows related to OpenEXRCore, but I didn't try to figure out why it's happening on one Windows build but not another. Any thoughts on what went wrong?

@remia
Copy link
Copy Markdown
Collaborator Author

remia commented Mar 19, 2022

There seems to be an analysis build failure on Windows related to OpenEXRCore, but I didn't try to figure out why it's happening on one Windows build but not another. Any thoughts on what went wrong?

Hi @doug-walker, this is the issue I mentioned in the PR description, OpenEXR doesn't compile on Windows MSVC 2022 currently, while the issue has now been fixed upstream, it's not released yet. I expect the analysis build will be fixed when that is the case. We shouldn't wait for this however.

remia added 7 commits March 23, 2022 21:18
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
@hodoulp hodoulp merged commit 4fa9491 into AcademySoftwareFoundation:main Mar 24, 2022
@remia remia deleted the build-fix branch April 27, 2022 21:03
luadebug added a commit to xmake-io/xmake-repo that referenced this pull request Jul 5, 2025
star-hengxing added a commit to xmake-io/xmake-repo that referenced this pull request Jul 6, 2025
* opencolorio: add v2.4.2

* Update xmake.lua

* Update xmake.lua

* Update xmake.lua

* fix yaml-cpp

* Fix GCC 15 according to AcademySoftwareFoundation/OpenColorIO#1599

* fix macosx minizip-ng

* limit mingw

---------

Co-authored-by: Saikari <lin@sz.cn.eu.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants