Adsk Contrib - More code cleanup#1365
Merged
hodoulp merged 4 commits intoAcademySoftwareFoundation:masterfrom Apr 22, 2021
Merged
Adsk Contrib - More code cleanup#1365hodoulp merged 4 commits intoAcademySoftwareFoundation:masterfrom
hodoulp merged 4 commits intoAcademySoftwareFoundation:masterfrom
Conversation
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
michdolan
approved these changes
Apr 21, 2021
doug-walker
approved these changes
Apr 22, 2021
hodoulp
added a commit
that referenced
this pull request
Apr 26, 2021
* Adsk Contrib - More code cleanup Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Fix build breaks Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
hodoulp
added a commit
that referenced
this pull request
Apr 29, 2021
* Adsk Contrib - More code cleanup (#1365) * Adsk Contrib - More code cleanup Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Fix build breaks Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Fix a new warning Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Hodoul Patrick.Hodoul@autodesk.com
Following a discussion around the issue #1213, we discovered that a usual gcc flag was missing i.e.
-Wextra. So, I've added it by default, and fixed all the warnings.