[Performance] LDM optimization patches#15824
Merged
AUTOMATIC1111 merged 3 commits intoAUTOMATIC1111:devfrom Jun 8, 2024
Merged
[Performance] LDM optimization patches#15824AUTOMATIC1111 merged 3 commits intoAUTOMATIC1111:devfrom
AUTOMATIC1111 merged 3 commits intoAUTOMATIC1111:devfrom
Conversation
Contributor
Author
|
I think #18620 might need to be merged before tests will pass on this. |
Collaborator
so we need to wait 2769 new posts to merge this 🙃 |
Contributor
Author
|
Upon further review I think it would be sufficient for #15820 to be merged first lol |
Contributor
Author
|
Added another patch, and it passes tests now. |
AUTOMATIC1111
approved these changes
Jun 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change 1: Timestep Embedding Patch
Change 2: SpatialTransformer.forward einops removal
.contiguous()call.aten::copy_andvoid at::native::elementwise_kernel<128, 4, at::nati...per forward pass (SD 1.5). Speedup seems to be around 6-8 ms per forward, but my profiler is being a little inconsistent with the timing (512x512, batch 4, overclocked 3090)Checklist: