fix 10896 pnginfo parameters#10905
Merged
Merged
Conversation
1 task
AUTOMATIC1111
approved these changes
Jun 1, 2023
Collaborator
Author
AUTOMATIC1111
added a commit
that referenced
this pull request
Jun 2, 2023
…ters fix 10896 pnginfo parameters
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #10896
remove the two lines that causes the parameters to be overwritten by upscaling
to be honest I don't know what the point of
existing_pnginfo['parameters'] = geninfoit seems to only cause troublefrom what I can tell when generate images (txt2img)
existing_pnginfo['parameters']always equalsgeninfoso there's no point of reassigning itand when you upscaling in extra tab, that lines essentially overrides the generation parameters
as far I can tell this change the final pnginfo back to what it was like in 1.2.1
you may want to do some testing yourself to make sure that I didn't overlook something