Refactor AverageAffineTransformFunction#1684
Conversation
|
NoRigid is an important variant and at one time was the recommended default
when initializing with a reference space (eg MNI)
On Wed, Feb 28, 2024 at 12:32 PM Dženan Zukić ***@***.***> wrote:
Remove NoRigid variant, and add useRigid and verbose iVars to
AverageAffineTransformFunction.
Removal of NoRigid variant is a code simplification.
Addition of verbosity flag allows use from libraries where debug output is
not expected and undesirable.
------------------------------
You can view, comment on, or merge this pull request online at:
#1684
Commit Summary
- e9ec28e
<e9ec28e>
ENH: Refactor AverageAffineTransformFunction (remove NoRigid variant)
- 51ee305
<51ee305>
ENH: Control AverageAffineTransformFunction's verbosity via an ivar
File Changes
(5 files <https://github.com/ANTsX/ANTs/pull/1684/files>)
- *M* Examples/AverageAffineTransformNoRigid.cxx
<https://github.com/ANTsX/ANTs/pull/1684/files#diff-be29f61ca8c2fe5f364e08bd69786fd8a33c5a305ab6cef9ec7bceec8f073b71>
(5)
- *M* Utilities/itkAverageAffineTransformFunction.h
<https://github.com/ANTsX/ANTs/pull/1684/files#diff-7ff5df59e0c5e073eb75890bfbc5bc0fbc68487401e70d3bf71f717de802830f>
(29)
- *M* Utilities/itkAverageAffineTransformFunction.hxx
<https://github.com/ANTsX/ANTs/pull/1684/files#diff-1b42509fc070f4d3434e0d06c405c9e4c6283f1e49fa9c4a55a95e5abce91d1c>
(159)
- *D* Utilities/itkAverageAffineTransformNoRigidFunction.h
<https://github.com/ANTsX/ANTs/pull/1684/files#diff-ee7d8c4733454c8848f6675b47292df66cf992ea7ed2fe63e27f1703ff228fc6>
(200)
- *D* Utilities/itkAverageAffineTransformNoRigidFunction.hxx
<https://github.com/ANTsX/ANTs/pull/1684/files#diff-5989927b2ce200b19dfdd77d3cc12ccc626e4865bb10a8826502df9d29fe11cf>
(344)
Patch Links:
- https://github.com/ANTsX/ANTs/pull/1684.patch
- https://github.com/ANTsX/ANTs/pull/1684.diff
—
Reply to this email directly, view it on GitHub
<#1684>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACPE7WFUTSFX7VEVJ3N76DYV5S3FAVCNFSM6AAAAABD6OL4A6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2TSNBXGUYTQMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
brian
|
|
It's functionality still exists, and has been moved to the main function: |
|
This impacts some of the template construction scripts and those would need updating. |
|
This looks like it's backwards compatible, just refactors how the "no affine" average is computed. |
|
@cookpa you are correct. Computation of |
|
@gdevenyi The executable |
|
Ok, this was unclear to me from the initial comment.
|
cookpa
left a comment
There was a problem hiding this comment.
The code simplification looks great. How about we make verbose=false by default and have the executable set verbose = true?
If I remember rightly, non-verbose back end code is useful for other ANTsX implementations.
|
Sure, a new commit is incoming. |
Verbose is off by default in the class. Executables turn on verbosity for backwards compatibility.
51ee305 to
911eadf
Compare
Remove
NoRigidvariant, and adduseRigidandverboseiVars toAverageAffineTransformFunction.Removal of
NoRigidvariant is a code simplification.Addition of verbosity flag allows use from libraries where debug output is not expected and undesirable.