Fix amount calculation for liquidity purchases in csv export#124
Merged
Conversation
Depending on the `payment_type`, fees for a liquidity purchases may be paid from the balance, or from future htlcs. In the former case, we must count the fee amount must be deducted from balance immediately. A helper method `InboundLiquidityOutgoingPayment.feePaidFromChannelBalance` has been introduced for that purpose in ACINQ/lightning-kmp#706 and we must use it.
dpad85
approved these changes
Oct 18, 2024
vincenzopalazzo
pushed a commit
to vincenzopalazzo/phoenixd
that referenced
this pull request
Nov 7, 2024
Depending on the `payment_type`, fees for a liquidity purchases may be paid from the balance, or from future htlcs. In the former case, we must count the fee amount must be deducted from balance immediately. A helper method `InboundLiquidityOutgoingPayment.feePaidFromChannelBalance` has been introduced for that purpose in ACINQ/lightning-kmp#706 and we must use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on the
payment_type, fees for a liquidity purchase may be paid from the balance, or from future htlcs. In the former case, the fee amount must be deducted from the balance immediately.A helper method
InboundLiquidityOutgoingPayment.feePaidFromChannelBalancehas been introduced for that purpose inACINQ/lightning-kmp#706 and we must use it.