Conversation
fbd12f8 to
68a771d
Compare
dpad85
reviewed
Nov 18, 2024
Member
dpad85
left a comment
There was a problem hiding this comment.
I also prefer option c).
- option b) is less readable, because 1) we can't easily parse which dependency is used by which target by just reading the
build.gradle.ktsfile ; 2) the toml file is very busy. - option a) is the same, but somewhat worse since the data are put in the settings file.
Merged
pm47
added a commit
to ACINQ/phoenixd
that referenced
this pull request
Jan 30, 2025
See rationale in ACINQ/lightning-kmp#727.
pm47
added a commit
to ACINQ/phoenixd
that referenced
this pull request
Feb 4, 2025
See rationale in ACINQ/lightning-kmp#727.
pm47
added a commit
to ACINQ/phoenixd
that referenced
this pull request
Feb 4, 2025
See rationale in ACINQ/lightning-kmp#727.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version catalog is the best practice for managing dependencies. It makes it easier to track and update versions, and allows to centralize dependencies in a multi-module context. It is an alternative to the
buildSrcworkaround used in some of our projects.This PR does not update libraries versions.
Each commit offers an alternative approach:
a) define the version catalog in
settings.gradleb) define the version catalog in
libs.versions.tomlc) only manage versions (not full dependencies) in the version catalog
Option c) has my preference because we get all the benefit of centralizing versions, but we don't really need to define all dependencies in the version catalog if they are not used by several modules.