Simplify creation of commit tx outputs #3077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the actual commit tx output to CommitmentOutput. Add the 2nd-level HTLC output to InHtlc/OutHtlc.
4958c7b to
a122039
Compare
t-bast
approved these changes
May 6, 2025
Member
t-bast
left a comment
There was a problem hiding this comment.
Nice, this is indeed much simpler, thanks!
t-bast
added a commit
that referenced
this pull request
May 6, 2025
t-bast
added a commit
that referenced
this pull request
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We extend
CommitmentOutputto include the actualTxOutit represents in the commit tx, as well as 2nd-level HTLC success/timeout outputs.This way we can create the entire tree of commit tx outputs/2nd level HTLC outputs at once.